* [PATCH 29/30] rtc: rtc-vt8500: use devm_rtc_device_register()
2013-03-06 5:27 [PATCH 01/30] rtc: rtc-88pm80x: " Jingoo Han
@ 2013-03-06 5:36 ` Jingoo Han
0 siblings, 0 replies; 2+ messages in thread
From: Jingoo Han @ 2013-03-06 5:36 UTC (permalink / raw)
To: 'Andrew Morton'
Cc: linux-kernel, 'Alessandro Zummo', rtc-linux,
'Jingoo Han'
devm_rtc_device_register() is device managed and makes cleanup
paths simpler.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/rtc/rtc-vt8500.c | 8 ++------
1 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/rtc/rtc-vt8500.c b/drivers/rtc/rtc-vt8500.c
index a000bc0..92fbb00 100644
--- a/drivers/rtc/rtc-vt8500.c
+++ b/drivers/rtc/rtc-vt8500.c
@@ -252,7 +252,7 @@ static int vt8500_rtc_probe(struct platform_device *pdev)
writel(VT8500_RTC_CR_ENABLE,
vt8500_rtc->regbase + VT8500_RTC_CR);
- vt8500_rtc->rtc = rtc_device_register("vt8500-rtc", &pdev->dev,
+ vt8500_rtc->rtc = devm_rtc_device_register("vt8500-rtc", &pdev->dev,
&vt8500_rtc_ops, THIS_MODULE);
if (IS_ERR(vt8500_rtc->rtc)) {
ret = PTR_ERR(vt8500_rtc->rtc);
@@ -266,13 +266,11 @@ static int vt8500_rtc_probe(struct platform_device *pdev)
if (ret < 0) {
dev_err(&pdev->dev, "can't get irq %i, err %d\n",
vt8500_rtc->irq_alarm, ret);
- goto err_unreg;
+ goto err_return;
}
return 0;
-err_unreg:
- rtc_device_unregister(vt8500_rtc->rtc);
err_return:
return ret;
}
@@ -281,8 +279,6 @@ static int vt8500_rtc_remove(struct platform_device *pdev)
{
struct vt8500_rtc *vt8500_rtc = platform_get_drvdata(pdev);
- rtc_device_unregister(vt8500_rtc->rtc);
-
/* Disable alarm matching */
writel(0, vt8500_rtc->regbase + VT8500_RTC_IS);
--
1.7.2.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH 29/30] rtc: rtc-vt8500: use devm_rtc_device_register()
@ 2013-05-02 7:06 Tony Prisk
0 siblings, 0 replies; 2+ messages in thread
From: Tony Prisk @ 2013-05-02 7:06 UTC (permalink / raw)
To: akpm; +Cc: linux-kernel@vger.kernel.org, a.zummo, rtc-linux, akpm
I realise this is a rather trivial series but it would be nice if the
listed maintainers for the drivers had been notified as well.
Regards
Tony Prisk
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-02 7:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-02 7:06 [PATCH 29/30] rtc: rtc-vt8500: use devm_rtc_device_register() Tony Prisk
-- strict thread matches above, loose matches on Subject: below --
2013-03-06 5:27 [PATCH 01/30] rtc: rtc-88pm80x: " Jingoo Han
2013-03-06 5:36 ` [PATCH 29/30] rtc: rtc-vt8500: " Jingoo Han
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox