From: Chris Fries <ccfries@gmail.com>
To: c.fries@motorola.com, jason.hrycay@motorola.com,
jaegeuk.kim@samsung.com, linux-f2fs-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: [PATCH v2 1/2] f2fs: Continue to mount after failing recovery
Date: Thu, 02 May 2013 16:07:34 -0500 [thread overview]
Message-ID: <5182D596.10708@gmail.com> (raw)
From: Chris Fries <C.Fries@motorola.com>
When unable to roll forward the journal, we shouldn't bail out and
not mount, we should continue to attempt the mount. Bad recovery data
is likely unrecoverable at this point, and requiring the user to try
to mount again doesn't solve any issues.
Signed-off-by: Chris Fries <C.Fries@motorola.com>
Reviewed-by: Russell Knize <rknize2@motorola.com>
Reviewed-by: Jason Hrycay <jason.hrycay@motorola.com>
---
fs/f2fs/super.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
index 2643c49..d8f7ed3 100644
--- a/fs/f2fs/super.c
+++ b/fs/f2fs/super.c
@@ -649,10 +649,9 @@ static int f2fs_fill_super(struct super_block *sb, void *data, int silent)
/* recover fsynced data */
if (!test_opt(sbi, DISABLE_ROLL_FORWARD)) {
err = recover_fsync_data(sbi);
- if (err) {
- f2fs_msg(sb, KERN_ERR, "Failed to recover fsync data");
- goto free_root_inode;
- }
+ if (err)
+ f2fs_msg(sb, KERN_ERR,
+ "Cannot recover all fsync data, continue\n");
}
/* After POR, we can run background GC thread */
--
1.8.0
reply other threads:[~2013-05-02 21:04 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5182D596.10708@gmail.com \
--to=ccfries@gmail.com \
--cc=c.fries@motorola.com \
--cc=jaegeuk.kim@samsung.com \
--cc=jason.hrycay@motorola.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox