From: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
To: Takuya Yoshikawa <takuya.yoshikawa@gmail.com>
Cc: mtosatti@redhat.com, gleb@redhat.com, avi.kivity@gmail.com,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH v4 4/6] KVM: MMU: fast invalid all shadow pages
Date: Fri, 03 May 2013 14:00:49 +0800 [thread overview]
Message-ID: <51835291.20400@linux.vnet.ibm.com> (raw)
In-Reply-To: <20130503112729.942a04b2ba2566b35328f49e@gmail.com>
On 05/03/2013 10:27 AM, Takuya Yoshikawa wrote:
> On Sat, 27 Apr 2013 11:13:20 +0800
> Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com> wrote:
>
>> +/*
>> + * Fast invalid all shadow pages belong to @slot.
>> + *
>> + * @slot != NULL means the invalidation is caused the memslot specified
>> + * by @slot is being deleted, in this case, we should ensure that rmap
>> + * and lpage-info of the @slot can not be used after calling the function.
>> + *
>> + * @slot == NULL means the invalidation due to other reasons, we need
>
> The comment should explain what the "other reasons" are.
> But this API may better be split into two separate functions; it depends
> on the "other reasons".
NO.
>
>> + * not care rmap and lpage-info since they are still valid after calling
>> + * the function.
>> + */
>> +void kvm_mmu_invalid_memslot_pages(struct kvm *kvm,
>> + struct kvm_memory_slot *slot)
>
> You yourself is explaining this as "invalidation" in the comment.
> kvm_mmu_invalidate_shadow_pages_memslot() or something...
Umm, invalidate is a better name. Will update after collecting Marcelo, Gleb
and other guy's comments.
next prev parent reply other threads:[~2013-05-03 6:00 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-27 3:13 [PATCH v4 0/6] KVM: MMU: fast zap all shadow pages Xiao Guangrong
2013-04-27 3:13 ` [PATCH v4 1/6] KVM: MMU: drop unnecessary kvm_reload_remote_mmus Xiao Guangrong
2013-04-27 3:13 ` [PATCH v4 2/6] KVM: x86: introduce memslot_set_lpage_disallowed Xiao Guangrong
2013-05-03 2:10 ` Takuya Yoshikawa
2013-05-03 5:55 ` Xiao Guangrong
2013-04-27 3:13 ` [PATCH v4 3/6] KVM: MMU: introduce kvm_clear_all_lpage_info Xiao Guangrong
2013-05-03 2:15 ` Takuya Yoshikawa
2013-05-03 5:57 ` Xiao Guangrong
2013-04-27 3:13 ` [PATCH v4 4/6] KVM: MMU: fast invalid all shadow pages Xiao Guangrong
2013-05-03 1:05 ` Marcelo Tosatti
2013-05-03 5:52 ` Xiao Guangrong
2013-05-03 15:53 ` Marcelo Tosatti
2013-05-03 16:51 ` Xiao Guangrong
2013-05-04 0:52 ` Marcelo Tosatti
2013-05-04 0:56 ` Marcelo Tosatti
2013-05-06 3:39 ` Xiao Guangrong
2013-05-06 12:36 ` Gleb Natapov
2013-05-06 13:10 ` Xiao Guangrong
2013-05-06 17:24 ` Gleb Natapov
2013-05-06 17:45 ` Xiao Guangrong
2013-05-07 8:58 ` Gleb Natapov
2013-05-07 9:41 ` Xiao Guangrong
2013-05-07 10:00 ` Gleb Natapov
2013-05-07 14:33 ` Marcelo Tosatti
2013-05-07 14:56 ` Gleb Natapov
2013-05-07 15:09 ` Marcelo Tosatti
2013-05-08 10:41 ` Gleb Natapov
2013-05-06 19:50 ` Marcelo Tosatti
2013-05-07 3:39 ` Xiao Guangrong
2013-05-07 14:42 ` Marcelo Tosatti
2013-05-03 2:27 ` Takuya Yoshikawa
2013-05-03 6:00 ` Xiao Guangrong [this message]
2013-04-27 3:13 ` [PATCH v4 5/6] KVM: x86: use the fast way to invalid all pages Xiao Guangrong
2013-04-27 3:13 ` [PATCH v4 6/6] KVM: MMU: make kvm_mmu_zap_all preemptable Xiao Guangrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51835291.20400@linux.vnet.ibm.com \
--to=xiaoguangrong@linux.vnet.ibm.com \
--cc=avi.kivity@gmail.com \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=takuya.yoshikawa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).