From: Tony Prisk <linux@prisktech.co.nz>
To: Jingoo Han <jg1.han@samsung.com>
Cc: "'Andrew Morton'" <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org,
"'Alessandro Zummo'" <a.zummo@towertech.it>,
rtc-linux@googlegroups.com
Subject: Re: [PATCH 38/42] rtc: rtc-vt8500: remove unnecessary platform_set_drvdata()
Date: Fri, 03 May 2013 19:27:15 +1200 [thread overview]
Message-ID: <518366D3.4070009@prisktech.co.nz> (raw)
In-Reply-To: <003401ce47c8$cf834140$6e89c3c0$@samsung.com>
On 03/05/13 18:38, Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> (device-core: Ensure drvdata = NULL when no driver is bound).
> Thus, it is not needed to manually clear the device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/rtc/rtc-vt8500.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/rtc/rtc-vt8500.c b/drivers/rtc/rtc-vt8500.c
> index d89efee..c2d6331 100644
> --- a/drivers/rtc/rtc-vt8500.c
> +++ b/drivers/rtc/rtc-vt8500.c
> @@ -282,8 +282,6 @@ static int vt8500_rtc_remove(struct platform_device *pdev)
> /* Disable alarm matching */
> writel(0, vt8500_rtc->regbase + VT8500_RTC_IS);
>
> - platform_set_drvdata(pdev, NULL);
> -
> return 0;
> }
>
Acked-by: Tony Prisk <linux@prisktech.co.nz>
prev parent reply other threads:[~2013-05-03 7:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-03 6:38 [PATCH 38/42] rtc: rtc-vt8500: remove unnecessary platform_set_drvdata() Jingoo Han
2013-05-03 7:27 ` Tony Prisk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=518366D3.4070009@prisktech.co.nz \
--to=linux@prisktech.co.nz \
--cc=a.zummo@towertech.it \
--cc=akpm@linux-foundation.org \
--cc=jg1.han@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox