* [PATCH 38/42] rtc: rtc-vt8500: remove unnecessary platform_set_drvdata()
@ 2013-05-03 6:38 Jingoo Han
2013-05-03 7:27 ` Tony Prisk
0 siblings, 1 reply; 2+ messages in thread
From: Jingoo Han @ 2013-05-03 6:38 UTC (permalink / raw)
To: 'Andrew Morton'
Cc: linux-kernel, 'Alessandro Zummo', rtc-linux, Jingoo Han,
'Tony Prisk'
The driver core clears the driver data to NULL after device_release
or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
(device-core: Ensure drvdata = NULL when no driver is bound).
Thus, it is not needed to manually clear the device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/rtc/rtc-vt8500.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/rtc/rtc-vt8500.c b/drivers/rtc/rtc-vt8500.c
index d89efee..c2d6331 100644
--- a/drivers/rtc/rtc-vt8500.c
+++ b/drivers/rtc/rtc-vt8500.c
@@ -282,8 +282,6 @@ static int vt8500_rtc_remove(struct platform_device *pdev)
/* Disable alarm matching */
writel(0, vt8500_rtc->regbase + VT8500_RTC_IS);
- platform_set_drvdata(pdev, NULL);
-
return 0;
}
--
1.7.2.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 38/42] rtc: rtc-vt8500: remove unnecessary platform_set_drvdata()
2013-05-03 6:38 [PATCH 38/42] rtc: rtc-vt8500: remove unnecessary platform_set_drvdata() Jingoo Han
@ 2013-05-03 7:27 ` Tony Prisk
0 siblings, 0 replies; 2+ messages in thread
From: Tony Prisk @ 2013-05-03 7:27 UTC (permalink / raw)
To: Jingoo Han
Cc: 'Andrew Morton', linux-kernel, 'Alessandro Zummo',
rtc-linux
On 03/05/13 18:38, Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> (device-core: Ensure drvdata = NULL when no driver is bound).
> Thus, it is not needed to manually clear the device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/rtc/rtc-vt8500.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/rtc/rtc-vt8500.c b/drivers/rtc/rtc-vt8500.c
> index d89efee..c2d6331 100644
> --- a/drivers/rtc/rtc-vt8500.c
> +++ b/drivers/rtc/rtc-vt8500.c
> @@ -282,8 +282,6 @@ static int vt8500_rtc_remove(struct platform_device *pdev)
> /* Disable alarm matching */
> writel(0, vt8500_rtc->regbase + VT8500_RTC_IS);
>
> - platform_set_drvdata(pdev, NULL);
> -
> return 0;
> }
>
Acked-by: Tony Prisk <linux@prisktech.co.nz>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-03 7:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-03 6:38 [PATCH 38/42] rtc: rtc-vt8500: remove unnecessary platform_set_drvdata() Jingoo Han
2013-05-03 7:27 ` Tony Prisk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox