From: Lars-Peter Clausen <lars@metafoo.de>
To: Jingoo Han <jg1.han@samsung.com>
Cc: "'Andrew Morton'" <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org,
"'Alessandro Zummo'" <a.zummo@towertech.it>,
rtc-linux@googlegroups.com
Subject: Re: [PATCH 03/42] rtc: rtc-ab3100: remove unnecessary platform_set_drvdata()
Date: Fri, 03 May 2013 12:19:23 +0200 [thread overview]
Message-ID: <51838F2B.5020402@metafoo.de> (raw)
In-Reply-To: <001101ce47c6$9ca9e640$d5fdb2c0$@samsung.com>
On 05/03/2013 08:22 AM, Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> (device-core: Ensure drvdata = NULL when no driver is bound).
> Thus, it is not needed to manually clear the device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/rtc/rtc-ab3100.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/rtc/rtc-ab3100.c b/drivers/rtc/rtc-ab3100.c
> index 47a4f2c..572208d 100644
> --- a/drivers/rtc/rtc-ab3100.c
> +++ b/drivers/rtc/rtc-ab3100.c
> @@ -242,7 +242,6 @@ static int __init ab3100_rtc_probe(struct platform_device *pdev)
>
> static int __exit ab3100_rtc_remove(struct platform_device *pdev)
> {
> - platform_set_drvdata(pdev, NULL);
> return 0;
> }
Since it's empty you can remove the function altogether.
Same comment for all the other patches in this series where the function
ends up being empty
prev parent reply other threads:[~2013-05-03 10:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-03 6:22 [PATCH 03/42] rtc: rtc-ab3100: remove unnecessary platform_set_drvdata() Jingoo Han
2013-05-03 10:19 ` Lars-Peter Clausen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51838F2B.5020402@metafoo.de \
--to=lars@metafoo.de \
--cc=a.zummo@towertech.it \
--cc=akpm@linux-foundation.org \
--cc=jg1.han@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox