* [PATCH] ntp: Remove unused variable flags in __hardpps
@ 2013-05-03 21:27 Geert Uytterhoeven
2013-05-04 0:10 ` John Stultz
0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2013-05-03 21:27 UTC (permalink / raw)
To: John Stultz, Thomas Gleixner; +Cc: linux-kernel, Geert Uytterhoeven
kernel/time/ntp.c: In function ‘__hardpps’:
kernel/time/ntp.c:877: warning: unused variable ‘flags’
commit a076b2146fabb0894cae5e0189a8ba3f1502d737 ("ntp: Remove ntp_lock,
using the timekeeping locks to protect ntp state") removed its users,
but not the actual variable.
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
kernel/time/ntp.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/kernel/time/ntp.c b/kernel/time/ntp.c
index 12ff13a..8f5b3b9 100644
--- a/kernel/time/ntp.c
+++ b/kernel/time/ntp.c
@@ -874,7 +874,6 @@ static void hardpps_update_phase(long error)
void __hardpps(const struct timespec *phase_ts, const struct timespec *raw_ts)
{
struct pps_normtime pts_norm, freq_norm;
- unsigned long flags;
pts_norm = pps_normalize_ts(*phase_ts);
--
1.7.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ntp: Remove unused variable flags in __hardpps
2013-05-03 21:27 [PATCH] ntp: Remove unused variable flags in __hardpps Geert Uytterhoeven
@ 2013-05-04 0:10 ` John Stultz
0 siblings, 0 replies; 2+ messages in thread
From: John Stultz @ 2013-05-04 0:10 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: Thomas Gleixner, linux-kernel
On 05/03/2013 02:27 PM, Geert Uytterhoeven wrote:
> kernel/time/ntp.c: In function ‘__hardpps’:
> kernel/time/ntp.c:877: warning: unused variable ‘flags’
>
> commit a076b2146fabb0894cae5e0189a8ba3f1502d737 ("ntp: Remove ntp_lock,
> using the timekeeping locks to protect ntp state") removed its users,
> but not the actual variable.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Thanks for catching this!
Acked-by: John Stultz <john.stultz@linaro.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-04 0:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-03 21:27 [PATCH] ntp: Remove unused variable flags in __hardpps Geert Uytterhoeven
2013-05-04 0:10 ` John Stultz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).