From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754876AbcFTOJP (ORCPT ); Mon, 20 Jun 2016 10:09:15 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:39050 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752477AbcFTOJJ (ORCPT ); Mon, 20 Jun 2016 10:09:09 -0400 X-AuditID: cbfee61b-f798b6d00000114d-45-5767f64538c5 From: Bartlomiej Zolnierkiewicz To: Tomasz Figa Cc: Sylwester Nawrocki , Michael Turquette , Stephen Boyd , Kukjin Kim , Krzysztof Kozlowski , "linux-samsung-soc@vger.kernel.org" , linux-clk@vger.kernel.org, linux-arm-kernel , linux-kernel Subject: Re: [PATCH 3/3] clk: samsung: exynos5433: add CPU clocks configuration data and instantiate CPU clocks Date: Mon, 20 Jun 2016 15:57:23 +0200 Message-id: <5185433.qVhfPjJi8E@amdc1976> User-Agent: KMail/4.13.3 (Linux/3.13.0-79-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: References: <1464095957-25851-1-git-send-email-b.zolnierkie@samsung.com> <1464095957-25851-4-git-send-email-b.zolnierkie@samsung.com> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset=us-ascii X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrGLMWRmVeSWpSXmKPExsVy+t9jAV23b+nhBv+eM1u8fmFo0f/4NbPF psfXWC0+9txjtbi8aw6bxYzz+5gsLp5ytTj8pp3V4seZbhaLVbv+MDpweby/0crucbmvl8lj 56y77B6bVnWyeWxeUu/Rt2UVo8fnTXIB7FFcNimpOZllqUX6dglcGRfnbmEsWM5fsXf1LvYG xk6eLkZODgkBE4ndB1exQ9hiEhfurWfrYuTiEBJYyiix7/8URgjnK6PEv/u7mEGq2ASsJCa2 r2IEsUUE1CW+TelnByliFljOLPHp6Fugdg4OYYFCiQu3VEFqWARUJfZsecgKYvMKaEq0LDrB AmKLCnhJ9Gx/BDaHUyBY4tari1DLzjFKTOm/xATRICjxY/I9sAZmAXmJffunskLYWhLrdx5n msAoMAtJ2SwkZbOQlC1gZF7FKJFakFxQnJSea5SXWq5XnJhbXJqXrpecn7uJERwbz6R3MB7e 5X6IUYCDUYmHd4ZiergQa2JZcWXuIUYJDmYlEd7aj0Ah3pTEyqrUovz4otKc1OJDjNIcLEri vI//rwsTEkhPLEnNTk0tSC2CyTJxcEo1MDowv3HlOxonOa/+X+6193qGq2ybCt5+3O5lJ+WZ 7ntkx83HX8/f+rNM/FvHZ5VaJ6lIj/uJ/dEKZpk30ox1ubo2iQtl2Kzdsve31N+Y7xe157dY T8987ibDYdfAnjb7ZMFplc09K70c+Zen+sUsrz4tc+jqI6kPB6I2zLxWcV7EetWMSwY9lUos xRmJhlrMRcWJAFFTxKGJAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Saturday, June 18, 2016 11:57:30 PM Tomasz Figa wrote: > Hi Bart, Hi Tomek, > 2016-05-24 22:19 GMT+09:00 Bartlomiej Zolnierkiewicz : > > Add the CPU clocks configuration data and instantiate the CPU clocks > > type for Exynos5433. > > > > Cc: Kukjin Kim > > CC: Krzysztof Kozlowski > > Signed-off-by: Bartlomiej Zolnierkiewicz > > --- > > drivers/clk/samsung/clk-exynos5433.c | 72 ++++++++++++++++++++++++++++++++---- > > 1 file changed, 64 insertions(+), 8 deletions(-) > > Please see my comments inline. > > > diff --git a/drivers/clk/samsung/clk-exynos5433.c b/drivers/clk/samsung/clk-exynos5433.c > > index 6dd81ed..9ff6160 100644 > > --- a/drivers/clk/samsung/clk-exynos5433.c > > +++ b/drivers/clk/samsung/clk-exynos5433.c > [snip] > > static void __init exynos5433_cmu_apollo_init(struct device_node *np) > > @@ -3620,6 +3640,12 @@ static void __init exynos5433_cmu_apollo_init(struct device_node *np) > > ARRAY_SIZE(apollo_div_clks)); > > samsung_clk_register_gate(ctx, apollo_gate_clks, > > ARRAY_SIZE(apollo_gate_clks)); > > + > > + exynos_register_cpu_clock(ctx, CLK_SCLK_APOLLO, "apolloclk", > > + mout_apollo_p[0], mout_apollo_p[1], 0x200, > > + exynos5433_apolloclk_d, ARRAY_SIZE(exynos5433_apolloclk_d), > > + CLK_CPU_HAS_E5433_REGS_LAYOUT); > > Hmm, I guess the reason for patch 1/3 was that > exynos_register_cpu_clock() has to be called with the ctx pointer. > However samsung_cmu_register_one() returns the ctx pointer, so I guess > you could use that to avoid open-coding? It is more than need to use ctx pointer. Please see me reply to your review of patch 1/3. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics