From: Mathias Nyman <mathias.nyman@linux.intel.com>
To: Jingoo Han <jg1.han@samsung.com>
Cc: "'Grant Likely'" <grant.likely@secretlab.ca>,
"'Linus Walleij'" <linus.walleij@linaro.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/7] gpio: lynxpoint: remove unnecessary platform_set_drvdata()
Date: Mon, 06 May 2013 14:00:54 +0300 [thread overview]
Message-ID: <51878D66.4000502@linux.intel.com> (raw)
In-Reply-To: <001801ce4a09$cbf95800$63ec0800$@samsung.com>
On 05/06/2013 06:28 AM, Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> (device-core: Ensure drvdata = NULL when no driver is bound).
> Thus, it is not needed to manually clear the device driver data to NULL.
>
> Signed-off-by: Jingoo Han<jg1.han@samsung.com>
> ---
> drivers/gpio/gpio-lynxpoint.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/gpio/gpio-lynxpoint.c b/drivers/gpio/gpio-lynxpoint.c
> index 86c17de..761c470 100644
> --- a/drivers/gpio/gpio-lynxpoint.c
> +++ b/drivers/gpio/gpio-lynxpoint.c
> @@ -447,7 +447,6 @@ static int lp_gpio_remove(struct platform_device *pdev)
> err = gpiochip_remove(&lg->chip);
> if (err)
> dev_warn(&pdev->dev, "failed to remove gpio_chip.\n");
> - platform_set_drvdata(pdev, NULL);
> return 0;
> }
>
Acked-by: Mathias Nyman <mathias.nyman@linux.intel.com>
next prev parent reply other threads:[~2013-05-06 10:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-06 3:28 [PATCH 2/7] gpio: lynxpoint: remove unnecessary platform_set_drvdata() Jingoo Han
2013-05-06 11:00 ` Mathias Nyman [this message]
2013-05-30 16:43 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51878D66.4000502@linux.intel.com \
--to=mathias.nyman@linux.intel.com \
--cc=grant.likely@secretlab.ca \
--cc=jg1.han@samsung.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox