* [PATCH 2/7] gpio: lynxpoint: remove unnecessary platform_set_drvdata()
@ 2013-05-06 3:28 Jingoo Han
2013-05-06 11:00 ` Mathias Nyman
2013-05-30 16:43 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Jingoo Han @ 2013-05-06 3:28 UTC (permalink / raw)
To: 'Grant Likely'
Cc: 'Linus Walleij', linux-kernel, Jingoo Han,
'Mathias Nyman'
The driver core clears the driver data to NULL after device_release
or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
(device-core: Ensure drvdata = NULL when no driver is bound).
Thus, it is not needed to manually clear the device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/gpio/gpio-lynxpoint.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/gpio/gpio-lynxpoint.c b/drivers/gpio/gpio-lynxpoint.c
index 86c17de..761c470 100644
--- a/drivers/gpio/gpio-lynxpoint.c
+++ b/drivers/gpio/gpio-lynxpoint.c
@@ -447,7 +447,6 @@ static int lp_gpio_remove(struct platform_device *pdev)
err = gpiochip_remove(&lg->chip);
if (err)
dev_warn(&pdev->dev, "failed to remove gpio_chip.\n");
- platform_set_drvdata(pdev, NULL);
return 0;
}
--
1.7.2.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 2/7] gpio: lynxpoint: remove unnecessary platform_set_drvdata()
2013-05-06 3:28 [PATCH 2/7] gpio: lynxpoint: remove unnecessary platform_set_drvdata() Jingoo Han
@ 2013-05-06 11:00 ` Mathias Nyman
2013-05-30 16:43 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Mathias Nyman @ 2013-05-06 11:00 UTC (permalink / raw)
To: Jingoo Han; +Cc: 'Grant Likely', 'Linus Walleij', linux-kernel
On 05/06/2013 06:28 AM, Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> (device-core: Ensure drvdata = NULL when no driver is bound).
> Thus, it is not needed to manually clear the device driver data to NULL.
>
> Signed-off-by: Jingoo Han<jg1.han@samsung.com>
> ---
> drivers/gpio/gpio-lynxpoint.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/gpio/gpio-lynxpoint.c b/drivers/gpio/gpio-lynxpoint.c
> index 86c17de..761c470 100644
> --- a/drivers/gpio/gpio-lynxpoint.c
> +++ b/drivers/gpio/gpio-lynxpoint.c
> @@ -447,7 +447,6 @@ static int lp_gpio_remove(struct platform_device *pdev)
> err = gpiochip_remove(&lg->chip);
> if (err)
> dev_warn(&pdev->dev, "failed to remove gpio_chip.\n");
> - platform_set_drvdata(pdev, NULL);
> return 0;
> }
>
Acked-by: Mathias Nyman <mathias.nyman@linux.intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2/7] gpio: lynxpoint: remove unnecessary platform_set_drvdata()
2013-05-06 3:28 [PATCH 2/7] gpio: lynxpoint: remove unnecessary platform_set_drvdata() Jingoo Han
2013-05-06 11:00 ` Mathias Nyman
@ 2013-05-30 16:43 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2013-05-30 16:43 UTC (permalink / raw)
To: Jingoo Han; +Cc: Grant Likely, linux-kernel@vger.kernel.org, Mathias Nyman
On Mon, May 6, 2013 at 5:28 AM, Jingoo Han <jg1.han@samsung.com> wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> (device-core: Ensure drvdata = NULL when no driver is bound).
> Thus, it is not needed to manually clear the device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Patch applied with Mathias' ACK.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-05-30 16:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-06 3:28 [PATCH 2/7] gpio: lynxpoint: remove unnecessary platform_set_drvdata() Jingoo Han
2013-05-06 11:00 ` Mathias Nyman
2013-05-30 16:43 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox