* [PATCH 1/2] dma: at_hdmac: remove unnecessary platform_set_drvdata()
@ 2013-05-06 3:53 Jingoo Han
2013-05-06 11:53 ` Nicolas Ferre
2013-05-27 16:30 ` Vinod Koul
0 siblings, 2 replies; 3+ messages in thread
From: Jingoo Han @ 2013-05-06 3:53 UTC (permalink / raw)
To: 'Vinod Koul'
Cc: 'Dan Williams', linux-kernel, Jingoo Han,
'Nicolas Ferre'
The driver core clears the driver data to NULL after device_release
or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
(device-core: Ensure drvdata = NULL when no driver is bound).
Thus, it is not needed to manually clear the device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/dma/at_hdmac.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c
index e923cda..c093ab7 100644
--- a/drivers/dma/at_hdmac.c
+++ b/drivers/dma/at_hdmac.c
@@ -1472,7 +1472,6 @@ err_of_dma_controller_register:
dma_async_device_unregister(&atdma->dma_common);
dma_pool_destroy(atdma->dma_desc_pool);
err_pool_create:
- platform_set_drvdata(pdev, NULL);
free_irq(platform_get_irq(pdev, 0), atdma);
err_irq:
clk_disable(atdma->clk);
@@ -1497,7 +1496,6 @@ static int at_dma_remove(struct platform_device *pdev)
dma_async_device_unregister(&atdma->dma_common);
dma_pool_destroy(atdma->dma_desc_pool);
- platform_set_drvdata(pdev, NULL);
free_irq(platform_get_irq(pdev, 0), atdma);
list_for_each_entry_safe(chan, _chan, &atdma->dma_common.channels,
--
1.7.2.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] dma: at_hdmac: remove unnecessary platform_set_drvdata()
2013-05-06 3:53 [PATCH 1/2] dma: at_hdmac: remove unnecessary platform_set_drvdata() Jingoo Han
@ 2013-05-06 11:53 ` Nicolas Ferre
2013-05-27 16:30 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Nicolas Ferre @ 2013-05-06 11:53 UTC (permalink / raw)
To: Jingoo Han, 'Vinod Koul'; +Cc: 'Dan Williams', linux-kernel
On 06/05/2013 05:53, Jingoo Han :
> The driver core clears the driver data to NULL after device_release
> or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> (device-core: Ensure drvdata = NULL when no driver is bound).
> Thus, it is not needed to manually clear the device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> ---
> drivers/dma/at_hdmac.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c
> index e923cda..c093ab7 100644
> --- a/drivers/dma/at_hdmac.c
> +++ b/drivers/dma/at_hdmac.c
> @@ -1472,7 +1472,6 @@ err_of_dma_controller_register:
> dma_async_device_unregister(&atdma->dma_common);
> dma_pool_destroy(atdma->dma_desc_pool);
> err_pool_create:
> - platform_set_drvdata(pdev, NULL);
> free_irq(platform_get_irq(pdev, 0), atdma);
> err_irq:
> clk_disable(atdma->clk);
> @@ -1497,7 +1496,6 @@ static int at_dma_remove(struct platform_device *pdev)
> dma_async_device_unregister(&atdma->dma_common);
>
> dma_pool_destroy(atdma->dma_desc_pool);
> - platform_set_drvdata(pdev, NULL);
> free_irq(platform_get_irq(pdev, 0), atdma);
>
> list_for_each_entry_safe(chan, _chan, &atdma->dma_common.channels,
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] dma: at_hdmac: remove unnecessary platform_set_drvdata()
2013-05-06 3:53 [PATCH 1/2] dma: at_hdmac: remove unnecessary platform_set_drvdata() Jingoo Han
2013-05-06 11:53 ` Nicolas Ferre
@ 2013-05-27 16:30 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2013-05-27 16:30 UTC (permalink / raw)
To: Jingoo Han; +Cc: 'Dan Williams', linux-kernel, 'Nicolas Ferre'
On Mon, May 06, 2013 at 12:53:33PM +0900, Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> (device-core: Ensure drvdata = NULL when no driver is bound).
> Thus, it is not needed to manually clear the device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Applied both, Thanks
--
~Vinod
> ---
> drivers/dma/at_hdmac.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c
> index e923cda..c093ab7 100644
> --- a/drivers/dma/at_hdmac.c
> +++ b/drivers/dma/at_hdmac.c
> @@ -1472,7 +1472,6 @@ err_of_dma_controller_register:
> dma_async_device_unregister(&atdma->dma_common);
> dma_pool_destroy(atdma->dma_desc_pool);
> err_pool_create:
> - platform_set_drvdata(pdev, NULL);
> free_irq(platform_get_irq(pdev, 0), atdma);
> err_irq:
> clk_disable(atdma->clk);
> @@ -1497,7 +1496,6 @@ static int at_dma_remove(struct platform_device *pdev)
> dma_async_device_unregister(&atdma->dma_common);
>
> dma_pool_destroy(atdma->dma_desc_pool);
> - platform_set_drvdata(pdev, NULL);
> free_irq(platform_get_irq(pdev, 0), atdma);
>
> list_for_each_entry_safe(chan, _chan, &atdma->dma_common.channels,
> --
> 1.7.2.5
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-05-27 17:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-06 3:53 [PATCH 1/2] dma: at_hdmac: remove unnecessary platform_set_drvdata() Jingoo Han
2013-05-06 11:53 ` Nicolas Ferre
2013-05-27 16:30 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox