* [PATCH 1/2] i2c: i2c-bfin-twi: don`t free peripheral before it`s init successful
@ 2013-05-06 13:11 Libo Chen
2013-05-09 5:07 ` [uclinux-dist-devel] " Zhang, Sonic
0 siblings, 1 reply; 2+ messages in thread
From: Libo Chen @ 2013-05-06 13:11 UTC (permalink / raw)
To: wsa; +Cc: uclinux-dist-devel, linux-i2c, linux-kernel, Li Zefan
down out_error_no_irq. When platform_get_irq fail, no need to free peripheral
Signed-off-by: Libo Chen <libo.chen@huawei.com>
---
drivers/i2c/busses/i2c-bfin-twi.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/i2c/busses/i2c-bfin-twi.c b/drivers/i2c/busses/i2c-bfin-twi.c
index 05080c4..d38e05a 100644
--- a/drivers/i2c/busses/i2c-bfin-twi.c
+++ b/drivers/i2c/busses/i2c-bfin-twi.c
@@ -709,8 +709,8 @@ static int i2c_bfin_twi_probe(struct platform_device *pdev)
out_error_add_adapter:
free_irq(iface->irq, iface);
out_error_req_irq:
-out_error_no_irq:
peripheral_free_list((unsigned short *)pdev->dev.platform_data);
+out_error_no_irq:
out_error_pin_mux:
iounmap(iface->regs_base);
out_error_ioremap:
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [uclinux-dist-devel] [PATCH 1/2] i2c: i2c-bfin-twi: don`t free peripheral before it`s init successful
2013-05-06 13:11 [PATCH 1/2] i2c: i2c-bfin-twi: don`t free peripheral before it`s init successful Libo Chen
@ 2013-05-09 5:07 ` Zhang, Sonic
0 siblings, 0 replies; 2+ messages in thread
From: Zhang, Sonic @ 2013-05-09 5:07 UTC (permalink / raw)
To: Libo Chen, wsa@the-dreams.de
Cc: uclinux-dist-devel@blackfin.uclinux.org, Li Zefan,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Hi Libo,
>-----Original Message-----
>From: uclinux-dist-devel-bounces@blackfin.uclinux.org [mailto:uclinux-dist-devel-
>bounces@blackfin.uclinux.org] On Behalf Of Libo Chen
>Sent: Monday, May 06, 2013 9:11 PM
>To: wsa@the-dreams.de
>Cc: uclinux-dist-devel@blackfin.uclinux.org; Li Zefan; linux-i2c@vger.kernel.org;
>linux-kernel@vger.kernel.org
>Subject: [uclinux-dist-devel] [PATCH 1/2] i2c: i2c-bfin-twi: don`t free peripheral
>before it`s init successful
>
>
>down out_error_no_irq. When platform_get_irq fail, no need to free peripheral
>
>Signed-off-by: Libo Chen <libo.chen@huawei.com>
>---
> drivers/i2c/busses/i2c-bfin-twi.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/drivers/i2c/busses/i2c-bfin-twi.c b/drivers/i2c/busses/i2c-bfin-twi.c
>index 05080c4..d38e05a 100644
>--- a/drivers/i2c/busses/i2c-bfin-twi.c
>+++ b/drivers/i2c/busses/i2c-bfin-twi.c
>@@ -709,8 +709,8 @@ static int i2c_bfin_twi_probe(struct platform_device *pdev)
> out_error_add_adapter:
> free_irq(iface->irq, iface);
> out_error_req_irq:
>-out_error_no_irq:
> peripheral_free_list((unsigned short *)pdev->dev.platform_data);
>+out_error_no_irq:
> out_error_pin_mux:
> iounmap(iface->regs_base);
> out_error_ioremap:
You should exchange line out_error_no_irq: and line out_error_pin_mux: other than.
Could you send me a new patch?
Regards,
Sonic
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-09 5:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-06 13:11 [PATCH 1/2] i2c: i2c-bfin-twi: don`t free peripheral before it`s init successful Libo Chen
2013-05-09 5:07 ` [uclinux-dist-devel] " Zhang, Sonic
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox