Re: [PATCH V3 0/3] trace-cmd: Support a raw format for outputting timestamp

[Yoshihiro YUNOMAE <yoshihiro.yunomae.ez@hitachi.com>]

Hi Steven,

Would you review this patch for trace-cmd?

Thanks,
Yoshihiro YUNOMAE

(2013/04/25 8:12), Yoshihiro YUNOMAE wrote:
> Hi Steven,
>
> This patch series extracts the trace_clock file for switching outputting format
> of timestamp. This patch series uses the options feature, so trace-cmd keeps
> backward compatibility.
>
> In tsc or counter modes, trace-cmd should output timestamp not in the sec.usec
> format but in the raw format. For example, we will show results in trace-cmd
> report mode as follows by applying this patch series:
>
> <for local or global mode>
>              bash-9022  [000] 34984.109846: sched_wakeup:         comm=migration/3 pid=23 prio=0 success=1 target_cpu=003
>            <idle>-0     [002] 34984.109847: cpu_idle:             state=4294967295 cpu_id=2
>              bash-9022  [000] 34984.109848: sched_switch:         prev_comm=bash prev_pid=9022 prev_prio=120 prev_state=R ==> next_comm=migration/0 next_pid=8 next_prio=0
>            <idle>-0     [002] 34984.109849: sched_switch:         prev_comm=swapper/2 prev_pid=0 prev_prio=120 prev_state=R ==> next_comm=migration/2 next_pid=18 next_prio=0
>
> <for tsc or counter mode>
>              bash-9022  [000] 34984109846: sched_wakeup:         comm=migration/3 pid=23 prio=0 success=1 target_cpu=003
>            <idle>-0     [002] 34984109847: cpu_idle:             state=4294967295 cpu_id=2
>              bash-9022  [000] 34984109848: sched_switch:         prev_comm=bash prev_pid=9022 prev_prio=120 prev_state=R ==> next_comm=migration/0 next_pid=8 next_prio=0
>            <idle>-0     [002] 34984109849: sched_switch:         prev_comm=swapper/2 prev_pid=0 prev_prio=120 prev_state=R ==> next_comm=migration/2 next_pid=18 next_prio=0
>
> v2:
>   - Separate input/output patches (2/3 and 3/3)
>   - Define TRACECMD_OPTION_TRACECLOCK for extracting trace_clock (2/3)
>   - Check whether TRACECMD_OPTION_TRACECLOCK exists or not in trace.dat (3/3)
>
> v3:
>   - a file variable in save_tracing_file_data() is freed when operation is failed
>     (1/3)
>   - check the return value of get_tracing_file() in save_tracing_file_data()
>     (1/3)
>
> Thank you,
>
> ---
>
> Yoshihiro YUNOMAE (3):
>        trace-cmd: Define general functions for outputting/inputting saved_cmdlines
>        trace-cmd: Add recording to trace_clock
>        trace-cmd: Add support for extracting trace_clock in report
>
>
>   event-parse.c  |   50 ++++++++++++++++++++++++++++-------
>   event-parse.h  |    6 ++++
>   trace-cmd.h    |    3 ++
>   trace-input.c  |   79 ++++++++++++++++++++++++++++++++++++++++++++++----------
>   trace-output.c |   71 +++++++++++++++++++++++++++++++-------------------
>   trace-read.c   |    4 ++-
>   trace-record.c |    3 ++
>   trace-util.c   |   26 ++++++++++++++++++
>   8 files changed, 188 insertions(+), 54 deletions(-)
>

-- 
Yoshihiro YUNOMAE
Software Platform Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: yoshihiro.yunomae.ez@hitachi.com