public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: HATAYAMA Daisuke <d.hatayama@jp.fujitsu.com>
To: Vivek Goyal <vgoyal@redhat.com>
Cc: kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
	lisa.mitchell@hp.com, kumagai-atsushi@mxc.nes.nec.co.jp,
	ebiederm@xmission.com, zhangyanfei@cn.fujitsu.com,
	akpm@linux-foundation.org, cpw@sgi.com, jingbai.ma@hp.com
Subject: Re: [PATCH v4 5/8] vmcore: copy ELF note segments in the 2nd kernel per page vmcore objects
Date: Wed, 08 May 2013 13:57:46 +0900	[thread overview]
Message-ID: <5189DB4A.8020902@jp.fujitsu.com> (raw)
In-Reply-To: <20130507150840.GA12965@redhat.com>

(2013/05/08 0:08), Vivek Goyal wrote:
> On Tue, May 07, 2013 at 04:56:46PM +0900, HATAYAMA Daisuke wrote:
>> (2013/04/30 4:36), Vivek Goyal wrote:
>>> On Sat, Apr 13, 2013 at 09:21:33AM +0900, HATAYAMA Daisuke wrote:
>>>
>>> [..]
>>>> ELF notes are per-cpu, so total size of ELF note segments increases
>>>> according to the number of CPUs. The current maximum number of CPUs on
>>>> x86_64 is 5192, and there's already system with 4192 CPUs in SGI,
>>>> where total size amounts to 1MB. This can be larger in the neare
>>>> futrue or possibly even now on another architecture. Thus, to avoid
>>>> the case where memory allocation for large block fails, we allocate
>>>> vmcore objects per pages.
>>>
>>> IIRC, eric had suggested using vmalloc() and remap_vmalloc_range(). What's
>>> wrong with that? That should keep your vc_list relatively smaller.
>>>
>>
>> Yes, it's handy if it's possible to remap them in vmalloc space, but
>> the problem here is that remap_vmalloc_range requires the first
>> argument vma to cover full range of the requested map. This becomes
>> problem when requested area for mmap() overlaps multiple objects,
>> for example, ELF headers and memory refered to by the first PT_LOAD
>> program header.
>>
>> To use remap_vmalloc_range, it's necessary to prepare a new variant
>> similar to remap_pfn_range by which we can remap different objects
>> separately to a single vma.
>
> Ok. Is it hard to prepare one such variant. If we can write one, it will
> simplify the vmcore code.

I'll try to write it. Although I avoided implementing it once, now it 
looks relatively easy to implement thanks to vm_insert_page, which does 
all essential thing. All I have to do should be consider sanity-check only.

-- 
Thanks.
HATAYAMA, Daisuke


  reply	other threads:[~2013-05-08  4:58 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-13  0:21 [PATCH v4 0/8] kdump, vmcore: support mmap() on /proc/vmcore HATAYAMA Daisuke
2013-04-13  0:21 ` [PATCH v4 1/8] vmcore: allocate buffer for ELF headers on page-size alignment HATAYAMA Daisuke
2013-04-13  0:21 ` [PATCH v4 2/8] vmcore: clean up read_vmcore() HATAYAMA Daisuke
2013-04-13  0:21 ` [PATCH v4 3/8] vmcore, procfs: introduce MEM_TYPE_CURRENT_KERNEL flag to distinguish objects copied in 2nd kernel HATAYAMA Daisuke
2013-04-13  0:21 ` [PATCH v4 4/8] vmcore: Add helper function vmcore_add() HATAYAMA Daisuke
2013-04-13  0:21 ` [PATCH v4 5/8] vmcore: copy ELF note segments in the 2nd kernel per page vmcore objects HATAYAMA Daisuke
2013-04-29 19:36   ` Vivek Goyal
2013-05-07  7:56     ` HATAYAMA Daisuke
2013-05-07 15:08       ` Vivek Goyal
2013-05-08  4:57         ` HATAYAMA Daisuke [this message]
2013-04-13  0:21 ` [PATCH v4 6/8] vmcore: count holes generated by round-up operation for page boudary for size of /proc/vmcore HATAYAMA Daisuke
2013-04-13  0:21 ` [PATCH v4 7/8] vmcore: treat memory chunks referenced by PT_LOAD program header entries in page-size boundary in vmcore_list HATAYAMA Daisuke
2013-04-29 19:51   ` Vivek Goyal
2013-05-07  7:38     ` HATAYAMA Daisuke
2013-05-07 15:24       ` Vivek Goyal
2013-04-13  0:21 ` [PATCH v4 8/8] vmcore: support mmap() on /proc/vmcore HATAYAMA Daisuke
2013-04-25 13:38 ` [PATCH v4 0/8] kdump, " Cliff Wickman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5189DB4A.8020902@jp.fujitsu.com \
    --to=d.hatayama@jp.fujitsu.com \
    --cc=akpm@linux-foundation.org \
    --cc=cpw@sgi.com \
    --cc=ebiederm@xmission.com \
    --cc=jingbai.ma@hp.com \
    --cc=kexec@lists.infradead.org \
    --cc=kumagai-atsushi@mxc.nes.nec.co.jp \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lisa.mitchell@hp.com \
    --cc=vgoyal@redhat.com \
    --cc=zhangyanfei@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox