From: "H. Peter Anvin" <hpa@zytor.com>
To: Denis Efremov <yefremov.denis@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org, x86@kernel.org, trivial@kernel.org,
ldv-project@linuxtesting.org
Subject: Re: [PATCH 03/21] x86: remove inline marking of EXPORT_SYMBOL functions
Date: Thu, 09 May 2013 06:50:15 -0700 [thread overview]
Message-ID: <518BA997.20401@zytor.com> (raw)
In-Reply-To: <1368086323-9412-3-git-send-email-yefremov.denis@gmail.com>
On 05/09/2013 12:58 AM, Denis Efremov wrote:
> EXPORT_SYMBOL and inline directives are contradictory to each other.
> The patch fixes this inconsistency.
>
> Found by Linux Driver Verification project (linuxtesting.org).
Nice, but wrong.
They aren't contradictory; in gnu89 syntax this means "this can be
inline, but also create an out-of-line copy that others can call."
That being said, I haven't looked at the code to see if that makes
sense, but the statement isn't correct.
-hpa
next prev parent reply other threads:[~2013-05-09 13:50 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-09 7:57 [PATCH 00/21] Exported funtions that are marked inline Denis Efremov
2013-05-09 7:58 ` [PATCH 01/21] [SCSI] libiscsi: remove inline marking of EXPORT_SYMBOL functions Denis Efremov
2013-05-09 7:58 ` [PATCH 02/21] fs: " Denis Efremov
2013-05-09 8:07 ` Al Viro
2013-05-09 8:42 ` Denis
2013-05-09 7:58 ` [PATCH 03/21] x86: " Denis Efremov
2013-05-09 13:50 ` H. Peter Anvin [this message]
2013-05-09 7:58 ` [PATCH 04/21] NFC: " Denis Efremov
2013-05-09 7:58 ` [PATCH 05/21] 9p: " Denis Efremov
2013-05-09 9:19 ` [PATCH 06/21] staging: nvec: " Denis Efremov
2013-05-09 9:19 ` [PATCH 07/21] netfilter: nf_nat: " Denis Efremov
2013-05-09 9:47 ` David Laight
2013-05-09 9:19 ` [PATCH 08/21] iwlegacy: " Denis Efremov
2013-05-09 9:19 ` [PATCH 09/21] dw_dmac: " Denis Efremov
[not found] ` <CAHp75VfWzzevr6AQzE25P8FUXd=amzL5-XgkJXvbRDESF=M76A@mail.gmail.com>
2013-05-12 15:13 ` Viresh Kumar
2013-05-30 18:01 ` Vinod Koul
2013-05-09 9:19 ` [PATCH 10/21] mm: filemap: " Denis Efremov
2013-05-09 9:19 ` [PATCH 11/21] ipv4: ip_output: " Denis Efremov
2013-05-11 23:13 ` David Miller
2013-05-09 10:36 ` [PATCH 12/21] metag: delay: " Denis Efremov
2013-05-09 11:03 ` James Hogan
2013-05-09 10:36 ` [PATCH 13/21] openrisc: " Denis Efremov
2013-05-09 10:45 ` Will Deacon
2013-05-09 10:36 ` [PATCH 14/21] arm64: " Denis Efremov
2013-05-09 10:39 ` Catalin Marinas
2013-05-09 10:36 ` [PATCH 15/21] arch/tile: " Denis Efremov
2013-05-09 18:02 ` Chris Metcalf
2013-05-09 10:36 ` [PATCH 16/21] sparc: " Denis Efremov
2013-05-09 10:36 ` [PATCH 17/21] CRISv32: " Denis Efremov
2013-05-14 16:35 ` Jesper Nilsson
2013-05-09 10:36 ` [PATCH 18/21] m68k/sun3/: " Denis Efremov
2013-05-09 11:09 ` Geert Uytterhoeven
2013-05-09 10:36 ` [PATCH 19/21] MIPS: MSP71xx: " Denis Efremov
2013-05-09 10:36 ` [PATCH 20/21] powerpc/ps3: " Denis Efremov
2013-05-09 11:35 ` Geoff Levand
2013-05-17 16:05 ` Geert Uytterhoeven
2013-05-28 23:14 ` Geoff Levand
2013-05-09 10:36 ` [PATCH 21/21] ARM: " Denis Efremov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=518BA997.20401@zytor.com \
--to=hpa@zytor.com \
--cc=ldv-project@linuxtesting.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=trivial@kernel.org \
--cc=x86@kernel.org \
--cc=yefremov.denis@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox