public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Dave Jones <davej@redhat.com>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: SyS symbol munging.
Date: Fri, 10 May 2013 12:45:31 -0700	[thread overview]
Message-ID: <518D4E5B.10804@infradead.org> (raw)
In-Reply-To: <20130510123510.78c066f177a7a8e5dd9ec7e4@linux-foundation.org>

On 05/10/13 12:35, Andrew Morton wrote:
> On Fri, 10 May 2013 15:24:17 -0400 Dave Jones <davej@redhat.com> wrote:
> 
>> On Fri, May 10, 2013 at 12:14:54PM -0700, Andrew Morton wrote:
>>
>>  > [  163.953629] Call Trace:
>>  > [  163.957706]  [<ffffffff812be322>] ipcget+0x182/0x380
>>  > [  163.962123]  [<ffffffff810b99a5>] ?trace_hardirqs_on_caller+0x115/0x1e0
>>  > [  163.966752]  [<ffffffff812c559a>] SyS_shmget+0x5a/0x60
>>  > [  163.971163]  [<ffffffff812c47e0>] ? shm_close+0x140/0x140
>>  > [  163.975590]  [<ffffffff812c3e60>] ? shm_release+0x50/0x50
>>  > [  163.979991]  [<ffffffff812c3df0>] ? shm_get_unmapped_area+0x20/0x20
>>  > [  163.984499]  [<ffffffff816caa14>] tracesys+0xdd/0xe2
>>  
>> This has been bugging me for a while.
>> What's changing sys_shmget to SyS_shmget in that trace ? And why ?
>>
> 
> nm vmlinux | grep SyS
> 
> That's the actual name of the function definition which the C compiler
> sees.  It's emitted by SYSCALL_DEFINE, cooked up by all the macro goop
> in include/linux/syscalls.h.
> 
> I forget who did this initially and peeling back those layers with git
> is tiresome.
> --

$ git blame include/linux/syscalls.h | grep SyS | more
07fe6e00 (Al Viro                  2013-01-21 15:03:44 -0500 189) 	asmlinka
ge long SyS##name(__MAP(x,__SC_LONG,__VA_ARGS__))	\
6c597963 (Heiko Carstens           2009-02-11 13:04:38 -0800 196) 	SYSCALL_
ALIAS(sys##name, SyS##name);


Those 2 commits explain (to some degree) what the patches do, but not why "SyS".


-- 
~Randy

  reply	other threads:[~2013-05-10 19:46 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-10 19:24 SyS symbol munging Dave Jones
2013-05-10 19:35 ` Andrew Morton
2013-05-10 19:45   ` Randy Dunlap [this message]
2013-05-10 19:55   ` Borislav Petkov
2013-05-10 20:05     ` Al Viro
2013-05-10 20:17       ` Borislav Petkov
2013-05-10 20:56       ` Steven Rostedt
2013-05-10 21:17         ` Al Viro
2013-05-10 19:40 ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=518D4E5B.10804@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=davej@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox