public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Rajnoha <prajnoha@redhat.com>
To: Mike Snitzer <snitzer@redhat.com>
Cc: "Darrick J. Wong" <darrick.wong@oracle.com>,
	device-mapper development <dm-devel@redhat.com>,
	linux-kernel@vger.kernel.org, Joe Thornber <thornber@redhat.com>
Subject: Re: [PATCH 2/2] dmcache: Implement a flush message
Date: Mon, 13 May 2013 14:04:08 +0200	[thread overview]
Message-ID: <5190D6B8.7020905@redhat.com> (raw)
In-Reply-To: <20130511152523.GA18988@redhat.com>

On 11.05.2013 17:25, Mike Snitzer wrote:> On Fri, May 10 2013 at  1:51pm
-0400,
> Darrick J. Wong <darrick.wong@oracle.com> wrote:
>
...
>> afaict, there isn't anything in the initscripts that tears down dm
devices
>> prior to invoking reboot(), and the kernel drivers don't have reboot
notifiers
>> to flush things out either.  I've been told that lvm does this, but I
don't see
>> anything in the Ubuntu or RHEL6 that would suggest a teardown script...
>
> See:
https://git.fedorahosted.org/cgit/lvm2.git/commit/?id=c698ee14bbb1310cf2383c8977d14a8e29139f8c
>
> But I'm not sure which distros have hooked blkdeactivate in (cc'ing
> prajnoha for his insight).
>

The blk-availability initscript/systemd unit that gets called at
shutdown/reboot and which in turn calls the blkdeactivate is already
used in RHEL 6.4 onwards and also in Fedora 18 onwards. However, for
Fedora, you need to enable the systemd unit explicitly at the moment
(systemctl enable blk-availability.service). To have it enabled by
default, the distro-wide default systemd configuration needs to be
edited which is controlled by systemd-preset file (I hope F19 is going
to have this enabled by default finally).

As for any other distros, it's up to the maintainers in that distro to
make use of the new script - I haven't looked if they started using it
or not. But upstream already provides it since lvm2 v2.02.98.

Peter

  reply	other threads:[~2013-05-13 12:04 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-08 21:48 dm-cache not writing out cache metadata at reboot? Darrick J. Wong
2013-05-08 22:05 ` Mike Snitzer
2013-05-08 23:23   ` Darrick J. Wong
2013-05-09 20:36   ` Darrick J. Wong
2013-05-09 20:44     ` [PATCH 1/2] dmcache: flush superblock stats when retrieving status info Darrick J. Wong
2013-05-10 10:10       ` Joe Thornber
2013-05-10 12:53         ` Mike Snitzer
2013-05-09 20:47     ` dm-cache not writing out cache metadata at reboot? Mike Snitzer
2013-05-09 20:47     ` [PATCH 2/2] dmcache: Implement a flush message Darrick J. Wong
2013-05-10 10:22       ` [dm-devel] " Joe Thornber
2013-05-10 17:51         ` Darrick J. Wong
2013-05-11 15:25           ` Mike Snitzer
2013-05-13 12:04             ` Peter Rajnoha [this message]
2013-05-13 21:36               ` [dm-devel] " Darrick J. Wong
2013-05-10 10:05   ` [dm-devel] dm-cache not writing out cache metadata at reboot? Joe Thornber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5190D6B8.7020905@redhat.com \
    --to=prajnoha@redhat.com \
    --cc=darrick.wong@oracle.com \
    --cc=dm-devel@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=snitzer@redhat.com \
    --cc=thornber@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox