From: Matt Fleming <matt.fleming@intel.com>
To: Lingzhu Xiang <lxiang@redhat.com>
Cc: Jeremy Kerr <jk@ozlabs.org>,
Matthew Garrett <matthew.garrett@nebula.com>,
linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org,
Josh Boyer <jwboyer@redhat.com>, "Lee, Chun-Yi" <jlee@suse.com>,
Andy Whitcroft <apw@canonical.com>
Subject: Re: [PATCH] efivarfs: Never return ENOENT from firmware again
Date: Mon, 13 May 2013 20:21:47 +0100 [thread overview]
Message-ID: <51913D4B.2000606@intel.com> (raw)
In-Reply-To: <5b6476bf31dc699a0e6f3983e78447eeac34d831.1368180585.git.lxiang@redhat.com>
On 05/10/2013 11:29 AM, Lingzhu Xiang wrote:
> Previously in 1fa7e69 efi_status_to_err() translated firmware status
> EFI_NOT_FOUND to -EIO instead of -ENOENT for efivarfs operations to
> avoid confusion. After refactoring in e14ab23, it is also used in other
> places where the translation may be unnecessary.
>
> So move the translation to efivarfs specific code. Also return EOF
> for reading zero-length files, which is what users would expect.
>
> Cc: Josh Boyer <jwboyer@redhat.com>
> Cc: Jeremy Kerr <jk@ozlabs.org>
> Cc: Lee, Chun-Yi <jlee@suse.com>
> Cc: Andy Whitcroft <apw@canonical.com>
> Signed-off-by: Lingzhu Xiang <lxiang@redhat.com>
> ---
> This is to be applied against mainline or Matt Fleming's chainsaw branch.
Applied, thanks.
FYI, I rebased my 'urgent' branch on v3.10-rc1, so your patch now
applies there too.
next prev parent reply other threads:[~2013-05-13 19:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-10 10:29 [PATCH] efivarfs: Never return ENOENT from firmware again Lingzhu Xiang
2013-05-13 19:21 ` Matt Fleming [this message]
2013-05-14 4:36 ` joeyli
2013-05-14 7:16 ` Matt Fleming
2013-05-14 8:32 ` joeyli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51913D4B.2000606@intel.com \
--to=matt.fleming@intel.com \
--cc=apw@canonical.com \
--cc=jk@ozlabs.org \
--cc=jlee@suse.com \
--cc=jwboyer@redhat.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lxiang@redhat.com \
--cc=matthew.garrett@nebula.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox