From: Alex Shi <alex.shi@intel.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: mingo@redhat.com, tglx@linutronix.de, akpm@linux-foundation.org,
bp@alien8.de, pjt@google.com, namhyung@kernel.org, efault@gmx.de,
morten.rasmussen@arm.com, vincent.guittot@linaro.org,
preeti@linux.vnet.ibm.com, viresh.kumar@linaro.org,
linux-kernel@vger.kernel.org, mgorman@suse.de, riel@redhat.com,
wangyun@linux.vnet.ibm.com
Subject: Re: [patch v6 6/8] sched: compute runnable load avg in cpu_load and cpu_avg_load_per_task
Date: Tue, 14 May 2013 08:51:40 +0800 [thread overview]
Message-ID: <51918A9C.1010002@intel.com> (raw)
In-Reply-To: <20130513140625.GA15136@twins.programming.kicks-ass.net>
On 05/13/2013 10:06 PM, Peter Zijlstra wrote:
>> > static void update_cpu_load_active(struct rq *this_rq)
>> > {
>> > + unsigned long load;
>> > +
>> > +#ifdef CONFIG_SMP
>> > + load = this_rq->cfs.runnable_load_avg;
>> > +#else
>> > + load = this_rq->load.weight;
>> > +#endif
>> > /*
>> > * See the mess around update_idle_cpu_load() / update_cpu_load_nohz().
> This just smells like you want a helper function... :-)
Yes, thanks for point out this!
>
> Also it doesn't apply anymore due to Paul Gortemaker moving some of this
> stuff about.
Will rebase on this. Thanks again! :)
--
Thanks
Alex
next prev parent reply other threads:[~2013-05-14 0:51 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-10 15:17 [patch 0/8]: use runnable load avg in balance Alex Shi
2013-05-10 15:17 ` [patch v6 1/8] Revert "sched: Introduce temporary FAIR_GROUP_SCHED dependency for load-tracking" Alex Shi
2013-05-10 15:17 ` [patch v6 2/8] sched: move few runnable tg variables into CONFIG_SMP Alex Shi
2013-05-10 15:17 ` [patch v6 3/8] sched: set initial value of runnable avg for new forked task Alex Shi
2013-05-16 6:28 ` Alex Shi
2013-05-10 15:17 ` [patch v6 4/8] sched: fix slept time double counting in enqueue entity Alex Shi
2013-05-10 15:17 ` [patch v6 5/8] sched: update cpu load after task_tick Alex Shi
2013-05-10 15:17 ` [patch v6 6/8] sched: compute runnable load avg in cpu_load and cpu_avg_load_per_task Alex Shi
2013-05-13 14:06 ` Peter Zijlstra
2013-05-14 0:51 ` Alex Shi [this message]
2013-05-14 7:27 ` Alex Shi
2013-05-16 5:49 ` Michael Wang
2013-05-16 6:58 ` Alex Shi
2013-05-10 15:17 ` [patch v6 7/8] sched: consider runnable load average in move_tasks Alex Shi
2013-05-10 15:17 ` [patch v6 8/8] sched: remove blocked_load_avg in tg Alex Shi
2013-05-14 8:31 ` Peter Zijlstra
2013-05-14 11:35 ` Alex Shi
2013-05-16 9:23 ` Peter Zijlstra
2013-05-23 7:32 ` Changlong Xie
2013-05-23 8:19 ` Alex Shi
2013-05-28 13:36 ` Alex Shi
2013-05-14 9:05 ` Paul Turner
2013-05-14 11:37 ` Alex Shi
2013-05-29 17:00 ` Jason Low
2013-05-30 0:44 ` Alex Shi
2013-05-14 8:07 ` [patch 0/8]: use runnable load avg in balance Alex Shi
2013-05-14 9:34 ` Paul Turner
2013-05-14 14:35 ` Alex Shi
2013-05-16 7:29 ` Michael Wang
2013-05-16 7:35 ` Alex Shi
2013-05-28 13:31 ` Alex Shi
2013-05-29 13:28 ` Alex Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51918A9C.1010002@intel.com \
--to=alex.shi@intel.com \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=morten.rasmussen@arm.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=preeti@linux.vnet.ibm.com \
--cc=riel@redhat.com \
--cc=tglx@linutronix.de \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
--cc=wangyun@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).