From: Stephen Warren <swarren@wwwdotorg.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: rjw@sisk.pl, linaro-kernel@lists.linaro.org, patches@linaro.org,
cpufreq@vger.kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, robin.randhawa@arm.com,
Steve.Bannister@arm.com, Liviu.Dudau@arm.com,
charles.garcia-tobin@arm.com, arvind.chauhan@arm.com,
Sekhar Nori <nsekhar@ti.com>, Ben Dooks <ben-linux@fluff.org>,
Kukjin Kim <kgene.kim@samsung.com>,
Simon Horman <horms@verge.net.au>,
Magnus Damm <magnus.damm@gmail.com>,
Ralf Baechle <ralf@linux-mips.org>, Arnd Bergmann <arnd@arndb.de>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Olof Johansson <olof@lixom.net>,
Srinidhi Kasagar <srinidhi.kasagar@stericsson.com>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH V1 resend] cpufreq: Raname index as data in cpufreq_frequency_table
Date: Tue, 14 May 2013 10:15:33 -0600 [thread overview]
Message-ID: <51926325.2050805@wwwdotorg.org> (raw)
In-Reply-To: <CAKohpo=MS6D9DGiZDUPPYA47c=tqWXUMC6bdssD5xL=7GEcDvw@mail.gmail.com>
On 05/14/2013 07:46 AM, Viresh Kumar wrote:
...
> This must address your concerns:
> @Rafael: I have attached both patches now for you to apply.
>
> From: Viresh Kumar <viresh.kumar@linaro.org>
> Date: Tue, 14 May 2013 19:08:50 +0530
> Subject: [PATCH 1/2] cpufreq: tegra: Remove irrelevant comment
>
> Tegra cpufreq driver doesn't use .index field of cpufreq_frequency_table and so
> comment mentioning order of .index is irrelevant. Remove it.
> diff --git a/drivers/cpufreq/tegra-cpufreq.c b/drivers/cpufreq/tegra-cpufreq.c
> -/* Frequency table index must be sequential starting at 0 */
> static struct cpufreq_frequency_table freq_table[] = {
> { 0, 216000 },
> { 1, 312000 },
Does the .index/.data field even need to be filled in any more?
next prev parent reply other threads:[~2013-05-14 16:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-13 12:57 [PATCH V1 resend] cpufreq: Raname index as data in cpufreq_frequency_table Viresh Kumar
2013-05-13 16:27 ` Stephen Warren
2013-05-13 16:45 ` Viresh Kumar
2013-05-14 13:46 ` Viresh Kumar
2013-05-14 16:15 ` Stephen Warren [this message]
2013-05-15 6:25 ` Viresh Kumar
2013-05-15 16:24 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51926325.2050805@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=Liviu.Dudau@arm.com \
--cc=Steve.Bannister@arm.com \
--cc=arnd@arndb.de \
--cc=arvind.chauhan@arm.com \
--cc=ben-linux@fluff.org \
--cc=benh@kernel.crashing.org \
--cc=charles.garcia-tobin@arm.com \
--cc=cpufreq@vger.kernel.org \
--cc=horms@verge.net.au \
--cc=kgene.kim@samsung.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=nsekhar@ti.com \
--cc=olof@lixom.net \
--cc=patches@linaro.org \
--cc=paulus@samba.org \
--cc=ralf@linux-mips.org \
--cc=rjw@sisk.pl \
--cc=robin.randhawa@arm.com \
--cc=srinidhi.kasagar@stericsson.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox