From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758785Ab3EOL5E (ORCPT ); Wed, 15 May 2013 07:57:04 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:46196 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755975Ab3EOL5B (ORCPT ); Wed, 15 May 2013 07:57:01 -0400 Message-ID: <519377EA.8070105@ti.com> Date: Wed, 15 May 2013 06:56:26 -0500 From: Dan Murphy User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130329 Thunderbird/17.0.5 MIME-Version: 1.0 To: Nishanth Menon CC: , , , , , , Subject: Re: [PATCH v3] ARM:dts:omap4-panda:Update the LED support for the panda DTS References: <1368541076-6854-1-git-send-email-dmurphy@ti.com> <20130515052916.GA15607@kahuna> In-Reply-To: <20130515052916.GA15607@kahuna> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org NM On 05/15/2013 12:29 AM, Nishanth Menon wrote: > $subject - add a space? > s/ARM:dts:omap4-panda:Update/ARM: dts: omap4-panda: Update/ ? Will fix. > On 09:17-20130514, Dan Murphy wrote: >> The GPIO for LED D1 on the omap4-panda a1-a3 rev and the omap4-panda-es >> are different. >> >> A1-A3 = gpio_wk7 > Thanks for fixing this - this is a key fix else, GPIO_7 which controls > VSEL for VDD_MPU on PandaBoard-ES will create all kind of ruckus (change > voltage on heartbeat)! >> ES = gpio_110 >> >> There is no change to LED D2 >> >> Abstract away the pinmux and the LED definitions for the two boards into >> the respective DTS files. >> >> Signed-off-by: Dan Murphy >> --- > [...] >> diff --git a/arch/arm/boot/dts/omap4-panda-es.dts b/arch/arm/boot/dts/omap4-panda-es.dts >> index f1d8c21..8d1ba03 100644 >> --- a/arch/arm/boot/dts/omap4-panda-es.dts >> +++ b/arch/arm/boot/dts/omap4-panda-es.dts >> @@ -34,3 +34,43 @@ >> 0x5e 0x100 /* hdmi_sda.hdmi_sda INPUT | MODE 0 */ >> >; >> }; >> + >> +&leds { >> + compatible = "gpio-leds"; >> + heartbeat { >> + label = "pandaboard::status1"; >> + gpios = <&gpio4 14 0>; >> + linux,default-trigger = "heartbeat"; >> + }; >> + mmc { >> + label = "pandaboard::status2"; >> + gpios = <&gpio1 8 0>; >> + linux,default-trigger = "gpio"; > mmc0? Good point why would I call it mmc and then set the trigger to gpio. Will fix it. >> + }; >> +}; >> + > Other that that, > Tested-by: Nishanth Menon -- ------------------ Dan Murphy