* [PATCH] qmi_wwan: Added support for Cinterion's PLxx WWAN Interface
@ 2013-05-15 12:28 Schmiedl Christian
2013-05-15 13:21 ` Sergei Shtylyov
0 siblings, 1 reply; 7+ messages in thread
From: Schmiedl Christian @ 2013-05-15 12:28 UTC (permalink / raw)
To: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Cc: Schemmel Hans-Christoph
/drivers/net/usb/qmi_wwan.c: Added support for Cinterion's PLxx WWAN Interface
by adding QMI_FIXED_INTF with Cinterion's Vendor ID as well as Product ID and
WWAN Interface Number.
Signed-off-by: Hans-Christoph Schemmel <hans-christoph.schemmel <at> gemalto.com>
Signed-off-by: Christian Schmiedl <christian.schmiedl <at> gemalto.com>
---
patch is against linux-3.9
--- linux-3.9/drivers/net/usb/qmi_wwan.c.orig 2013-05-06 08:10:11.170034451 +0200
+++ linux-3.9/drivers/net/usb/qmi_wwan.c 2013-05-06 08:58:00.800264179 +0200
<at> <at> -569,6 +569,7 <at> <at> static const struct usb_device_id produc
{QMI_FIXED_INTF(0x1bbb, 0x011e, 4)}, /* Telekom Speedstick LTE II (Alcatel One Touch L100V LTE) */
{QMI_FIXED_INTF(0x2357, 0x0201, 4)}, /* TP-LINK HSUPA Modem MA180 */
{QMI_FIXED_INTF(0x1bc7, 0x1200, 5)}, /* Telit LE920 */
+ {QMI_FIXED_INTF(0x1e2d, 0x12d1, 4)}, /* Cinterion PLxx */
/* 4. Gobi 1000 devices */
{QMI_GOBI1K_DEVICE(0x05c6, 0x9212)}, /* Acer Gobi Modem Device */
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] qmi_wwan: Added support for Cinterion's PLxx WWAN Interface
2013-05-15 12:28 [PATCH] qmi_wwan: Added support for Cinterion's PLxx WWAN Interface Schmiedl Christian
@ 2013-05-15 13:21 ` Sergei Shtylyov
0 siblings, 0 replies; 7+ messages in thread
From: Sergei Shtylyov @ 2013-05-15 13:21 UTC (permalink / raw)
To: Schmiedl Christian
Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
Schemmel Hans-Christoph
Hello.
On 15-05-2013 16:28, Schmiedl Christian wrote:
> /drivers/net/usb/qmi_wwan.c: Added support for Cinterion's PLxx WWAN Interface
> by adding QMI_FIXED_INTF with Cinterion's Vendor ID as well as Product ID and
> WWAN Interface Number.
> Signed-off-by: Hans-Christoph Schemmel <hans-christoph.schemmel <at> gemalto.com>
> Signed-off-by: Christian Schmiedl <christian.schmiedl <at> gemalto.com>
> ---
> patch is against linux-3.9
> --- linux-3.9/drivers/net/usb/qmi_wwan.c.orig 2013-05-06 08:10:11.170034451 +0200
> +++ linux-3.9/drivers/net/usb/qmi_wwan.c 2013-05-06 08:58:00.800264179 +0200
> <at> <at> -569,6 +569,7 <at> <at> static const struct usb_device_id produc
Your patch is corrupt. From the "<at> <at>" it seems the corruptor
was gmane. :-)
WBR, Sergei
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] qmi_wwan: Added support for Cinterion's PLxx WWAN Interface
@ 2013-05-15 13:44 Schmiedl Christian
2013-05-16 10:30 ` Bjørn Mork
0 siblings, 1 reply; 7+ messages in thread
From: Schmiedl Christian @ 2013-05-15 13:44 UTC (permalink / raw)
To: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Cc: Schemmel Hans-Christoph
/drivers/net/usb/qmi_wwan.c: Added support for Cinterion's PLxx WWAN Interface
by adding QMI_FIXED_INTF with Cinterion's Vendor ID as well as Product ID and
WWAN Interface Number.
Signed-off-by: Hans-Christoph Schemmel <hans-christoph.schemmel@gemalto.com>
Signed-off-by: Christian Schmiedl <christian.schmiedl@gemalto.com>
---
patch is against linux-3.9
--- linux-3.9/drivers/net/usb/qmi_wwan.c.orig 2013-05-06 08:10:11.170034451 +0200
+++ linux-3.9/drivers/net/usb/qmi_wwan.c 2013-05-06 08:58:00.800264179 +0200
@@ -569,6 +569,7 @@ static const struct usb_device_id produc
{QMI_FIXED_INTF(0x1bbb, 0x011e, 4)}, /* Telekom Speedstick LTE II (Alcatel One Touch L100V LTE) */
{QMI_FIXED_INTF(0x2357, 0x0201, 4)}, /* TP-LINK HSUPA Modem MA180 */
{QMI_FIXED_INTF(0x1bc7, 0x1200, 5)}, /* Telit LE920 */
+ {QMI_FIXED_INTF(0x1e2d, 0x12d1, 4)}, /* Cinterion PLxx */
/* 4. Gobi 1000 devices */
{QMI_GOBI1K_DEVICE(0x05c6, 0x9212)}, /* Acer Gobi Modem Device */
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] qmi_wwan: Added support for Cinterion's PLxx WWAN Interface
2013-05-15 13:44 Schmiedl Christian
@ 2013-05-16 10:30 ` Bjørn Mork
0 siblings, 0 replies; 7+ messages in thread
From: Bjørn Mork @ 2013-05-16 10:30 UTC (permalink / raw)
To: Schmiedl Christian
Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
Schemmel Hans-Christoph
Schmiedl Christian <Christian.Schmiedl@gemalto.com> writes:
> /drivers/net/usb/qmi_wwan.c: Added support for Cinterion's PLxx WWAN Interface
> by adding QMI_FIXED_INTF with Cinterion's Vendor ID as well as Product ID and
> WWAN Interface Number.
Much better. But this patch need to go to the netdev list to get picked
up by the net patchworks and maintainer. It was posted there the last
time, so I don't understand why you dropped that now? The minimum To/Cc
list for usbnet drivers is:
netdev@vger.kernel.org, linux-usb@vger.kernel.org
Anything else is a bonus, and adding linux-kernel is of course fine.
Hint: Use linux/scripts/get_maintainer.pl to get a list of addresses to
send a patch to.
> Signed-off-by: Hans-Christoph Schemmel <hans-christoph.schemmel@gemalto.com>
> Signed-off-by: Christian Schmiedl <christian.schmiedl@gemalto.com>
This is of course fine, but the patch was sent by Hans-Christoph the
last time. If he is the original author, then you also want to preserve
that authorship in the git history (in addition to those SOBs). The
proper way to do that is to add a line like this as the first line of
the email body, followed by a single empty line:
From: Hans-Christoph Schemmel <hans-christoph.schemmel@gemalto.com>
This will make "git am" use Hans-Christoph as the author, even if the
patch is posted by you.
And since you obviously have to resend this anyway: Please drop the file
name ("/drivers/net/usb/qmi_wwan.c: ") from the commit message. It is
part of the patch itself, and including it in the commit message just
adds noise.
Thanks,
Bjørn
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] qmi_wwan: Added support for Cinterion's PLxx WWAN Interface
@ 2013-05-21 12:07 Schmiedl Christian
2013-05-21 13:19 ` Bjørn Mork
0 siblings, 1 reply; 7+ messages in thread
From: Schmiedl Christian @ 2013-05-21 12:07 UTC (permalink / raw)
To: netdev@vger.kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Schemmel Hans-Christoph
From: Hans-Christoph Schemmel <hans-christoph.schemmel@gemalto.com>
Added support for Cinterion's PLxx WWAN Interface by adding QMI_FIXED_INTF with
Cinterion's Vendor ID as well as Product ID and WWAN Interface Number.
Signed-off-by: Hans-Christoph Schemmel <hans-christoph.schemmel@gemalto.com>
Signed-off-by: Christian Schmiedl <christian.schmiedl@gemalto.com>
---
patch is against linux-3.9
--- linux-3.9/drivers/net/usb/qmi_wwan.c.orig 2013-05-06 08:10:11.170034451 +0200
+++ linux-3.9/drivers/net/usb/qmi_wwan.c 2013-05-06 08:58:00.800264179 +0200
@@ -569,6 +569,7 @@ static const struct usb_device_id produc
{QMI_FIXED_INTF(0x1bbb, 0x011e, 4)}, /* Telekom Speedstick LTE II (Alcatel One Touch L100V LTE) */
{QMI_FIXED_INTF(0x2357, 0x0201, 4)}, /* TP-LINK HSUPA Modem MA180 */
{QMI_FIXED_INTF(0x1bc7, 0x1200, 5)}, /* Telit LE920 */
+ {QMI_FIXED_INTF(0x1e2d, 0x12d1, 4)}, /* Cinterion PLxx */
/* 4. Gobi 1000 devices */
{QMI_GOBI1K_DEVICE(0x05c6, 0x9212)}, /* Acer Gobi Modem Device */
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] qmi_wwan: Added support for Cinterion's PLxx WWAN Interface
2013-05-21 12:07 Schmiedl Christian
@ 2013-05-21 13:19 ` Bjørn Mork
2013-05-22 22:13 ` David Miller
0 siblings, 1 reply; 7+ messages in thread
From: Bjørn Mork @ 2013-05-21 13:19 UTC (permalink / raw)
To: Schmiedl Christian
Cc: netdev@vger.kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, Schemmel Hans-Christoph
Schmiedl Christian <Christian.Schmiedl@gemalto.com> writes:
> From: Hans-Christoph Schemmel <hans-christoph.schemmel@gemalto.com>
>
> Added support for Cinterion's PLxx WWAN Interface by adding QMI_FIXED_INTF with
> Cinterion's Vendor ID as well as Product ID and WWAN Interface Number.
>
> Signed-off-by: Hans-Christoph Schemmel <hans-christoph.schemmel@gemalto.com>
> Signed-off-by: Christian Schmiedl <christian.schmiedl@gemalto.com>
> ---
> patch is against linux-3.9
> --- linux-3.9/drivers/net/usb/qmi_wwan.c.orig 2013-05-06 08:10:11.170034451 +0200
> +++ linux-3.9/drivers/net/usb/qmi_wwan.c 2013-05-06 08:58:00.800264179 +0200
> @@ -569,6 +569,7 @@ static const struct usb_device_id produc
> {QMI_FIXED_INTF(0x1bbb, 0x011e, 4)}, /* Telekom Speedstick LTE II (Alcatel One Touch L100V LTE) */
> {QMI_FIXED_INTF(0x2357, 0x0201, 4)}, /* TP-LINK HSUPA Modem MA180 */
> {QMI_FIXED_INTF(0x1bc7, 0x1200, 5)}, /* Telit LE920 */
> + {QMI_FIXED_INTF(0x1e2d, 0x12d1, 4)}, /* Cinterion PLxx */
>
> /* 4. Gobi 1000 devices */
> {QMI_GOBI1K_DEVICE(0x05c6, 0x9212)}, /* Acer Gobi Modem Device */
Acked-by: Bjørn Mork <bjorn@mork.no>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] qmi_wwan: Added support for Cinterion's PLxx WWAN Interface
2013-05-21 13:19 ` Bjørn Mork
@ 2013-05-22 22:13 ` David Miller
0 siblings, 0 replies; 7+ messages in thread
From: David Miller @ 2013-05-22 22:13 UTC (permalink / raw)
To: bjorn
Cc: Christian.Schmiedl, netdev, linux-usb, linux-kernel,
Hans-Christoph.Schemmel
From: Bjørn Mork <bjorn@mork.no>
Date: Tue, 21 May 2013 15:19:43 +0200
> Schmiedl Christian <Christian.Schmiedl@gemalto.com> writes:
>
>> From: Hans-Christoph Schemmel <hans-christoph.schemmel@gemalto.com>
>>
>> Added support for Cinterion's PLxx WWAN Interface by adding QMI_FIXED_INTF with
>> Cinterion's Vendor ID as well as Product ID and WWAN Interface Number.
>>
>> Signed-off-by: Hans-Christoph Schemmel <hans-christoph.schemmel@gemalto.com>
>> Signed-off-by: Christian Schmiedl <christian.schmiedl@gemalto.com>
...
> Acked-by: Bjørn Mork <bjorn@mork.no>
Applied.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2013-05-22 22:13 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-15 12:28 [PATCH] qmi_wwan: Added support for Cinterion's PLxx WWAN Interface Schmiedl Christian
2013-05-15 13:21 ` Sergei Shtylyov
-- strict thread matches above, loose matches on Subject: below --
2013-05-15 13:44 Schmiedl Christian
2013-05-16 10:30 ` Bjørn Mork
2013-05-21 12:07 Schmiedl Christian
2013-05-21 13:19 ` Bjørn Mork
2013-05-22 22:13 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox