From: "Jim Schutt" <jaschut@sandia.gov>
To: "Alex Elder" <elder@inktank.com>
Cc: ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] ceph: ceph_pagelist_append might sleep while atomic
Date: Wed, 15 May 2013 10:53:42 -0600 [thread overview]
Message-ID: <5193BD96.1000005@sandia.gov> (raw)
In-Reply-To: <5193BC89.6030807@inktank.com>
On 05/15/2013 10:49 AM, Alex Elder wrote:
> On 05/15/2013 11:38 AM, Jim Schutt wrote:
>> > Ceph's encode_caps_cb() worked hard to not call __page_cache_alloc() while
>> > holding a lock, but it's spoiled because ceph_pagelist_addpage() always
>> > calls kmap(), which might sleep. Here's the result:
> This looks good to me, but I admit I didn't take as close
> a look at it this time.
>
> I appreciate your updating the series to include the things
> I mentioned.
>
> I'll commit these for you, and I'll get confirmation on the
> byte order thing as well.
Cool. Thanks, Alex.
-- Jim
>
> Reviewed-by: Alex Elder <elder@inktank.com>
>
>
prev parent reply other threads:[~2013-05-15 16:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-15 16:38 [PATCH v2 0/3] ceph: fix might_sleep while atomic Jim Schutt
2013-05-15 16:38 ` [PATCH v2 1/3] ceph: fix up comment for ceph_count_locks() as to which lock to hold Jim Schutt
2013-05-15 16:42 ` Alex Elder
2013-05-15 16:38 ` [PATCH v2 2/3] ceph: add missing cpu_to_le32() calls when encoding a reconnect capability Jim Schutt
2013-05-15 16:43 ` Alex Elder
2013-05-16 0:10 ` Sage Weil
2013-05-15 16:38 ` [PATCH v2 3/3] ceph: ceph_pagelist_append might sleep while atomic Jim Schutt
2013-05-15 16:49 ` Alex Elder
2013-05-15 16:53 ` Jim Schutt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5193BD96.1000005@sandia.gov \
--to=jaschut@sandia.gov \
--cc=ceph-devel@vger.kernel.org \
--cc=elder@inktank.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox