From: David Cohen <david.a.cohen@intel.com>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: grant.likely@secretlab.ca, linus.walleij@linaro.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gpio-langwell: fix irq conflicts when DT is not used
Date: Wed, 15 May 2013 10:01:12 -0700 [thread overview]
Message-ID: <5193BF58.1030805@intel.com> (raw)
In-Reply-To: <51892D29.7030803@intel.com>
Hi Grant,
On 05/07/2013 09:34 AM, David Cohen wrote:
> On 05/07/2013 12:59 AM, Mika Westerberg wrote:
>> On Mon, May 06, 2013 at 04:11:03PM -0700, David Cohen wrote:
>>> When DT is not used IOAPIC does not register irq domain. As result
>>> IOAPIC won't care about gpio-langwell's virq and may cause conflict if
>>> an irq number is equal to gpio-langwell's virq mapped beforehand.
>>>
>>> This patch tells gpio_langwell to not ignore irq_base if != 0 and
>>> preferably use it to avoid the conflict.
>>>
>>> If DT is used, irq_base can safely be 0.
>>>
>>> Signed-off-by: David Cohen <david.a.cohen@intel.com>
>> Presuming that you have tested this on Medfield and it still works
>> there.
>
> Medfield and Clovertrail :)
>
> Br, David
>
>>
>> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Kindly ping :)
Comments?
Br, David
next prev parent reply other threads:[~2013-05-15 16:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-06 23:11 [PATCH] gpio-langwell: fix irq conflicts when DT is not used David Cohen
2013-05-07 7:59 ` Mika Westerberg
2013-05-07 16:34 ` David Cohen
2013-05-15 17:01 ` David Cohen [this message]
2013-05-20 18:13 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5193BF58.1030805@intel.com \
--to=david.a.cohen@intel.com \
--cc=grant.likely@secretlab.ca \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox