From: David Ahern <dsahern@gmail.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@kernel.org>,
Namhyung Kim <namhyung.kim@lge.com>,
LKML <linux-kernel@vger.kernel.org>, Jiri Olsa <jolsa@redhat.com>,
Stephane Eranian <eranian@google.com>,
Andi Kleen <andi@firstfloor.org>,
Pekka Enberg <penberg@kernel.org>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>
Subject: Re: [RFC/PATCH 1/2] perf script: Add --time-filter option
Date: Wed, 15 May 2013 20:42:30 -0600 [thread overview]
Message-ID: <51944796.7020505@gmail.com> (raw)
In-Reply-To: <87sj1n4rh3.fsf@sejong.aot.lge.com>
On 5/15/13 7:56 PM, Namhyung Kim wrote:
>> How about just --time? less typing.
>
> Thanks, I'm fine with '--time' too but '--time-filter' looks more
yes, I just have really long command lines now. Is there a consistent
single letter (X?)?
> obvious. What does the timehist command do, btw? ;)
task scheduling time history including run time and time between
sched-in. It needs to be updated to use tracepoints and perhaps fold
into perf-sched (e.g., perf sched history). Too many features; too
little time. I hope to get to it in the next month or so.
>> I would expect parse_nsec_time to fail. e.g., a time string like 123455.a
>
> It looks like current strtol() returns 0 when failed to parse like
> above. Hmm.. do I have to check whether the return value is 0 or just
> ignore invalid inputs?
end will point to the next character not converted so make sure it is as
expected (*end == '\0').
David
next prev parent reply other threads:[~2013-05-16 2:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-15 9:23 [RFC/PATCH 1/2] perf script: Add --time-filter option Namhyung Kim
2013-05-15 9:23 ` [RFC/PATCH 2/2] perf report: " Namhyung Kim
2013-05-15 11:51 ` Stephane Eranian
2013-05-16 0:48 ` Namhyung Kim
2013-05-15 13:56 ` [RFC/PATCH 1/2] perf script: " Andi Kleen
2013-05-16 0:55 ` Namhyung Kim
2013-05-16 13:09 ` Ingo Molnar
2013-05-15 15:16 ` David Ahern
2013-05-16 1:56 ` Namhyung Kim
2013-05-16 2:42 ` David Ahern [this message]
2013-05-16 8:50 ` Namhyung Kim
2013-05-16 13:29 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51944796.7020505@gmail.com \
--to=dsahern@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=andi@firstfloor.org \
--cc=eranian@google.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung.kim@lge.com \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox