* [PATCH] mm, slab: corrected the comment 'kmem_cache_alloc' to 'slab_alloc_node'
@ 2013-05-15 17:10 Zhouping Liu
2013-05-15 18:10 ` Pekka Enberg
0 siblings, 1 reply; 3+ messages in thread
From: Zhouping Liu @ 2013-05-15 17:10 UTC (permalink / raw)
To: linux-mm
Cc: Zhouping Liu, Christoph Lameter, Pekka Enberg, Matt Mackall,
linux-kernel
From: Zhouping Liu <zliu@redhat.com>
commit 48356303ff(mm, slab: Rename __cache_alloc() -> slab_alloc())
forgot to update the comment 'kmem_cache_alloc' to 'slab_alloc_node'.
Signed-off-by: Zhouping Liu <zliu@redhat.com>
---
mm/slab.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/slab.c b/mm/slab.c
index 8ccd296..8efb5f7 100644
--- a/mm/slab.c
+++ b/mm/slab.c
@@ -3339,7 +3339,7 @@ done:
}
/**
- * kmem_cache_alloc_node - Allocate an object on the specified node
+ * slab_alloc_node - Allocate an object on the specified node
* @cachep: The cache to allocate from.
* @flags: See kmalloc().
* @nodeid: node number of the target node.
--
1.7.11.7
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mm, slab: corrected the comment 'kmem_cache_alloc' to 'slab_alloc_node'
2013-05-15 17:10 [PATCH] mm, slab: corrected the comment 'kmem_cache_alloc' to 'slab_alloc_node' Zhouping Liu
@ 2013-05-15 18:10 ` Pekka Enberg
2013-05-16 3:29 ` Zhouping Liu
0 siblings, 1 reply; 3+ messages in thread
From: Pekka Enberg @ 2013-05-15 18:10 UTC (permalink / raw)
To: Zhouping Liu
Cc: linux-mm@kvack.org, Zhouping Liu, Christoph Lameter, Matt Mackall,
LKML
On Wed, May 15, 2013 at 8:10 PM, Zhouping Liu <sanweidaying@gmail.com> wrote:
> From: Zhouping Liu <zliu@redhat.com>
>
> commit 48356303ff(mm, slab: Rename __cache_alloc() -> slab_alloc())
> forgot to update the comment 'kmem_cache_alloc' to 'slab_alloc_node'.
>
> Signed-off-by: Zhouping Liu <zliu@redhat.com>
> ---
> mm/slab.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/slab.c b/mm/slab.c
> index 8ccd296..8efb5f7 100644
> --- a/mm/slab.c
> +++ b/mm/slab.c
> @@ -3339,7 +3339,7 @@ done:
> }
>
> /**
> - * kmem_cache_alloc_node - Allocate an object on the specified node
> + * slab_alloc_node - Allocate an object on the specified node
> * @cachep: The cache to allocate from.
> * @flags: See kmalloc().
> * @nodeid: node number of the target node.
The point of the comment is to document kernel API and whereas
slab_alloc_node() is internal to the slab allocator. Can you please
just move it on top of kmem_cache_alloc_node() definition in the same
file?
Pekka
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mm, slab: corrected the comment 'kmem_cache_alloc' to 'slab_alloc_node'
2013-05-15 18:10 ` Pekka Enberg
@ 2013-05-16 3:29 ` Zhouping Liu
0 siblings, 0 replies; 3+ messages in thread
From: Zhouping Liu @ 2013-05-16 3:29 UTC (permalink / raw)
To: Pekka Enberg
Cc: Zhouping Liu, linux-mm@kvack.org, Christoph Lameter, Matt Mackall,
LKML
On 05/16/2013 02:10 AM, Pekka Enberg wrote:
> On Wed, May 15, 2013 at 8:10 PM, Zhouping Liu <sanweidaying@gmail.com> wrote:
>> From: Zhouping Liu <zliu@redhat.com>
>>
>> commit 48356303ff(mm, slab: Rename __cache_alloc() -> slab_alloc())
>> forgot to update the comment 'kmem_cache_alloc' to 'slab_alloc_node'.
>>
>> Signed-off-by: Zhouping Liu <zliu@redhat.com>
>> ---
>> mm/slab.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/mm/slab.c b/mm/slab.c
>> index 8ccd296..8efb5f7 100644
>> --- a/mm/slab.c
>> +++ b/mm/slab.c
>> @@ -3339,7 +3339,7 @@ done:
>> }
>>
>> /**
>> - * kmem_cache_alloc_node - Allocate an object on the specified node
>> + * slab_alloc_node - Allocate an object on the specified node
>> * @cachep: The cache to allocate from.
>> * @flags: See kmalloc().
>> * @nodeid: node number of the target node.
> The point of the comment is to document kernel API and whereas
> slab_alloc_node() is internal to the slab allocator. Can you please
> just move it on top of kmem_cache_alloc_node() definition in the same
> file?
OK, thanks for reviewing, please check V2.
Thanks,
Zhouping
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-05-16 3:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-15 17:10 [PATCH] mm, slab: corrected the comment 'kmem_cache_alloc' to 'slab_alloc_node' Zhouping Liu
2013-05-15 18:10 ` Pekka Enberg
2013-05-16 3:29 ` Zhouping Liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox