From: Michael Wang <wangyun@linux.vnet.ibm.com>
To: Alex Shi <alex.shi@intel.com>
Cc: mingo@redhat.com, peterz@infradead.org, tglx@linutronix.de,
akpm@linux-foundation.org, bp@alien8.de, pjt@google.com,
namhyung@kernel.org, efault@gmx.de, morten.rasmussen@arm.com,
vincent.guittot@linaro.org, preeti@linux.vnet.ibm.com,
viresh.kumar@linaro.org, linux-kernel@vger.kernel.org,
mgorman@suse.de, riel@redhat.com
Subject: Re: [patch 0/8]: use runnable load avg in balance
Date: Thu, 16 May 2013 15:29:24 +0800 [thread overview]
Message-ID: <51948AD4.3020104@linux.vnet.ibm.com> (raw)
In-Reply-To: <1368199049-2798-1-git-send-email-alex.shi@intel.com>
On 05/10/2013 11:17 PM, Alex Shi wrote:
> This patchset bases on tip/sched/core.
>
> This version changed the runnable load avg value setting for new task
> in patch 3rd.
>
> We also tried to include blocked load avg in balance. but find many benchmark
> performance dropping. Guess the too bigger cpu load drive task to be waken
> on remote CPU, and cause wrong decision in periodic balance.
>
> I retested on Intel core2, NHM, SNB, IVB, 2 and 4 sockets machines with
> benchmark kbuild, aim7, dbench, tbench, hackbench, oltp, and netperf loopback
> etc. The performance is better now.
>
> On SNB EP 4 sockets machine, the hackbench increased about 50%, and result
> become stable. on other machines, hackbench increased about 2~10%.
> oltp increased about 30% in NHM EX box.
> netperf loopback also increased on SNB EP 4 sockets box.
> no clear changes on other benchmarks.
>
> Michael Wang had tested previous version on pgbench on his box:
> https://lkml.org/lkml/2013/4/2/1022
Tested the latest patch set (new 3/8 and 6/8) with pgbench, tip
3.10.0-rc1 and 12 cpu X86 box, works well and still benefit ;-)
Regards,
Michael Wang
>
> And Morten tested previous version too.
> http://comments.gmane.org/gmane.linux.kernel/1463371
>
> Thanks comments from Peter, Paul, Morten, Miacheal and Preeti.
> And more comments are appreciated!
>
> Regards
> Alex
>
> [patch v6 1/8] Revert "sched: Introduce temporary FAIR_GROUP_SCHED
> [patch v6 2/8] sched: move few runnable tg variables into CONFIG_SMP
> [patch v6 3/8] sched: set initial value of runnable avg for new
> [patch v6 4/8] sched: fix slept time double counting in enqueue
> [patch v6 5/8] sched: update cpu load after task_tick.
> [patch v6 6/8] sched: compute runnable load avg in cpu_load and
> [patch v6 7/8] sched: consider runnable load average in move_tasks
> [patch v6 8/8] sched: remove blocked_load_avg in tg
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
next prev parent reply other threads:[~2013-05-16 7:29 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-10 15:17 [patch 0/8]: use runnable load avg in balance Alex Shi
2013-05-10 15:17 ` [patch v6 1/8] Revert "sched: Introduce temporary FAIR_GROUP_SCHED dependency for load-tracking" Alex Shi
2013-05-10 15:17 ` [patch v6 2/8] sched: move few runnable tg variables into CONFIG_SMP Alex Shi
2013-05-10 15:17 ` [patch v6 3/8] sched: set initial value of runnable avg for new forked task Alex Shi
2013-05-16 6:28 ` Alex Shi
2013-05-10 15:17 ` [patch v6 4/8] sched: fix slept time double counting in enqueue entity Alex Shi
2013-05-10 15:17 ` [patch v6 5/8] sched: update cpu load after task_tick Alex Shi
2013-05-10 15:17 ` [patch v6 6/8] sched: compute runnable load avg in cpu_load and cpu_avg_load_per_task Alex Shi
2013-05-13 14:06 ` Peter Zijlstra
2013-05-14 0:51 ` Alex Shi
2013-05-14 7:27 ` Alex Shi
2013-05-16 5:49 ` Michael Wang
2013-05-16 6:58 ` Alex Shi
2013-05-10 15:17 ` [patch v6 7/8] sched: consider runnable load average in move_tasks Alex Shi
2013-05-10 15:17 ` [patch v6 8/8] sched: remove blocked_load_avg in tg Alex Shi
2013-05-14 8:31 ` Peter Zijlstra
2013-05-14 11:35 ` Alex Shi
2013-05-16 9:23 ` Peter Zijlstra
2013-05-23 7:32 ` Changlong Xie
2013-05-23 8:19 ` Alex Shi
2013-05-28 13:36 ` Alex Shi
2013-05-14 9:05 ` Paul Turner
2013-05-14 11:37 ` Alex Shi
2013-05-29 17:00 ` Jason Low
2013-05-30 0:44 ` Alex Shi
2013-05-14 8:07 ` [patch 0/8]: use runnable load avg in balance Alex Shi
2013-05-14 9:34 ` Paul Turner
2013-05-14 14:35 ` Alex Shi
2013-05-16 7:29 ` Michael Wang [this message]
2013-05-16 7:35 ` Alex Shi
2013-05-28 13:31 ` Alex Shi
2013-05-29 13:28 ` Alex Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51948AD4.3020104@linux.vnet.ibm.com \
--to=wangyun@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=alex.shi@intel.com \
--cc=bp@alien8.de \
--cc=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=morten.rasmussen@arm.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=preeti@linux.vnet.ibm.com \
--cc=riel@redhat.com \
--cc=tglx@linutronix.de \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).