* [PATCH v2] kernel: debug: memcpy overlaped, use memmove instead of memcpy.
@ 2013-05-16 11:33 Chen Gang
0 siblings, 0 replies; only message in thread
From: Chen Gang @ 2013-05-16 11:33 UTC (permalink / raw)
To: jason.wessel; +Cc: kgdb-bugreport, linux-kernel@vger.kernel.org
For memcpy(), src and dest are overlaped: for default implementaion or
some architectures, it is OK, but we can not be sure that it is OK for
all platforms, and in this condition, the performance are not quite
important.
So let memmove instead of memcpy.
Signed-off-by: Chen Gang <gang.chen@asianux.com>
---
kernel/debug/kdb/kdb_support.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/debug/kdb/kdb_support.c b/kernel/debug/kdb/kdb_support.c
index d35cc2d..990b3cc 100644
--- a/kernel/debug/kdb/kdb_support.c
+++ b/kernel/debug/kdb/kdb_support.c
@@ -129,13 +129,13 @@ int kdbnearsym(unsigned long addr, kdb_symtab_t *symtab)
}
if (i >= ARRAY_SIZE(kdb_name_table)) {
debug_kfree(kdb_name_table[0]);
- memcpy(kdb_name_table, kdb_name_table+1,
+ memmove(kdb_name_table, kdb_name_table+1,
sizeof(kdb_name_table[0]) *
(ARRAY_SIZE(kdb_name_table)-1));
} else {
debug_kfree(knt1);
knt1 = kdb_name_table[i];
- memcpy(kdb_name_table+i, kdb_name_table+i+1,
+ memmove(kdb_name_table+i, kdb_name_table+i+1,
sizeof(kdb_name_table[0]) *
(ARRAY_SIZE(kdb_name_table)-i-1));
}
--
1.7.7.6
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2013-05-16 11:33 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-16 11:33 [PATCH v2] kernel: debug: memcpy overlaped, use memmove instead of memcpy Chen Gang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox