From: Sasha Levin <sasha.levin@oracle.com>
To: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>
Cc: "Liu, Chuansheng" <chuansheng.liu@intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Peter Zijlstra <peterz@infradead.org>,
"Wu, Fengguang" <fengguang.wu@intel.com>,
"eag0628@gmail.com" <eag0628@gmail.com>,
Dave Jones <davej@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
John Stultz <johnstul@us.ibm.com>
Subject: Re: WARNING: at kernel/smp.c:385 smp_call_function_many
Date: Thu, 16 May 2013 14:23:38 -0400 [thread overview]
Message-ID: <5195242A.4040007@oracle.com> (raw)
In-Reply-To: <51708FE5.6000301@oracle.com>
On 04/18/2013 08:29 PM, Sasha Levin wrote:
> Hi Liu,
>
> On 04/18/2013 08:10 PM, Liu, Chuansheng wrote:
>>> It seems that with commit "smp: Give WARN()ing when calling
>>>> smp_call_function_many()/single() in serving irq" I'm getting a bunch of these:
>> This patch gives the warning even when the smp_call_function_many() is called in softirq context,
>> because it will bring the possible deadlock cases, the example is below:
>> CPUA CPUB
>> spin_lock(&spinlock)
>> Any irq coming, call the irq handler
>> irq_exit()
>> spin_lock_irq(&spinlock)
>> <== Blocking here due to
>> CPUB hold it
>> __do_softirq()
>> run_timer_softirq()
>> timer_cb()
>> call smp_call_function_many()
>> send IPI interrupt to CPUA
>> wait_csd()
>>
>> Then both CPUA and CPUB will be deadlocked here.
>
> Right.
>
> So commit f55a6faa3 ("hrtimer: Provide clock_was_set_delayed()") followed by one
> of the commits that used clock_was_set_delayed() may trigger the deadlock you've
> described. (cc John Stultz...)
Ping?
Thanks,
Sasha
next prev parent reply other threads:[~2013-05-16 18:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-18 21:05 WARNING: at kernel/smp.c:385 smp_call_function_many Sasha Levin
2013-04-19 0:10 ` Liu, Chuansheng
2013-04-19 0:29 ` Sasha Levin
2013-05-16 18:23 ` Sasha Levin [this message]
2013-05-28 10:26 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5195242A.4040007@oracle.com \
--to=sasha.levin@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=chuansheng.liu@intel.com \
--cc=davej@redhat.com \
--cc=eag0628@gmail.com \
--cc=fengguang.wu@intel.com \
--cc=johnstul@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).