From: Kishon Vijay Abraham I <kishon@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: Tomi Valkeinen <tomi.valkeinen@iki.fi>, <linux@arm.linux.org.uk>,
<linux-omap@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <balbi@ti.com>
Subject: Re: [PATCH] ARM: OMAP4: change the device names in usb_bind_phy
Date: Fri, 17 May 2013 11:09:24 +0530 [thread overview]
Message-ID: <5195C28C.40300@ti.com> (raw)
In-Reply-To: <20130516162034.GX5600@atomide.com>
Hi,
On Thursday 16 May 2013 09:50 PM, Tony Lindgren wrote:
> * Tomi Valkeinen <tomi.valkeinen@iki.fi> [130516 09:11]:
>> On 16/05/13 18:58, Tony Lindgren wrote:
>>> * Tomi Valkeinen <tomi.valkeinen@iki.fi> [130515 03:59]:
>>>
>>> Just checking.. Do you have CONFIG_OMAP_OCP2SCP=y in your .config? Sounds
>>> like the some transceivers should depend on that for omap4.
>>
>> Yes, I have OCP2SCP=y.
>
> Hmm well no idea beyond that then. Sounds like Kishon should check it.
>
>>>> The musb-hdrc id is wrong on overo also.
>>>
>>> Hmm has there been a fix posted for that?
>>
>> I couldn't find with a quick look. We debugged and discussed this on an irc
>> channel with Kishon, who said he'll send a patch. Changing the musb-hdrc ID
>> on overo fixed the issue, and it looks very similar to the error on 4430sdp.
>> The overo fix was just:
hmm.. I think using device name to bind the controller and the phy can
no longer be used reliably. I think it's better to have something like
what Grant suggested in my other patch series.. to have the phy
reference into the host controllers platform_data structure. And for the
phy reference I'll have label and id.
Does this makes sense to you?
Thanks
Kishon
next prev parent reply other threads:[~2013-05-17 5:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-23 6:14 [PATCH] ARM: OMAP4: change the device names in usb_bind_phy Kishon Vijay Abraham I
2013-04-23 17:36 ` Tony Lindgren
2013-05-15 10:53 ` Tomi Valkeinen
2013-05-16 15:58 ` Tony Lindgren
2013-05-16 16:05 ` Tomi Valkeinen
2013-05-16 16:20 ` Tony Lindgren
2013-05-17 5:39 ` Kishon Vijay Abraham I [this message]
2013-05-17 17:23 ` Tony Lindgren
2013-05-21 12:08 ` Florian Vaussard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5195C28C.40300@ti.com \
--to=kishon@ti.com \
--cc=balbi@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=tomi.valkeinen@iki.fi \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox