public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Hector Palacios <hector.palacios@digi.com>
To: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "fabio.estevam@freescale.com" <fabio.estevam@freescale.com>,
	Marek Vasut <marex@denx.de>,
	"shawn.guo@linaro.org" <shawn.guo@linaro.org>
Subject: mxsfb on i.MX28 uses bypassed ref_xtal 24MHz clock for LCD
Date: Fri, 17 May 2013 15:57:46 +0200	[thread overview]
Message-ID: <5196375A.1070308@digi.com> (raw)

Hello,

I was testing the framebuffer on an i.MX28 based platform and found out that the lcdif 
clock is actually bypassed to use the ref_xtal of 24MHz, which makes the 
clk_set_rate() call in the driver useless (as well as the pixclock settings in 
fb_videomode variables in mach-mxs.c):

static void mxsfb_enable_controller(struct fb_info *fb_info)
{
	struct mxsfb_info *host = to_imxfb_host(fb_info);
	u32 reg;

	dev_dbg(&host->pdev->dev, "%s\n", __func__);

	clk_prepare_enable(host->clk);
	clk_set_rate(host->clk, PICOS2KHZ(fb_info->var.pixclock) * 1000U);

This can easily be checked by probing the pixel clock signal.
Is this known or did it go unnoticed because the supported displays work ok with the 
bypassed 24MHz frequency?
If using a pixel clock below 24MHz, the divisor will round to 2 thus generating a 
12MHz signal.

On the MX28EVK board with the Seiko 4.3" LCD, I do not see the penguin or any image in 
v3.8 or v3.9 though the framebuffer device is present and correctly loaded and 
backlight on.
This LCD works in kernel v2.6.35 with the same 24MHz frequency.
@Fabio, does this LCD work out of the box on v3.9? Am I missing something?

Thank you.
-- 
Héctor Palacios

             reply	other threads:[~2013-05-17 14:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-17 13:57 Hector Palacios [this message]
2013-05-17 14:07 ` mxsfb on i.MX28 uses bypassed ref_xtal 24MHz clock for LCD Fabio Estevam
2013-05-20 14:59   ` Hector Palacios
2013-05-20 15:11     ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5196375A.1070308@digi.com \
    --to=hector.palacios@digi.com \
    --cc=fabio.estevam@freescale.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marex@denx.de \
    --cc=shawn.guo@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox