From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756362Ab3EQT2z (ORCPT <rfc822;w@1wt.eu>);
	Fri, 17 May 2013 15:28:55 -0400
Received: from e28smtp04.in.ibm.com ([122.248.162.4]:33131 "EHLO
	e28smtp04.in.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755946Ab3EQT2x (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 17 May 2013 15:28:53 -0400
Message-ID: <5196843B.8060807@linux.vnet.ibm.com>
Date: Sat, 18 May 2013 00:55:47 +0530
From: "Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120828 Thunderbird/15.0
MIME-Version: 1.0
To: James Bottomley <James.Bottomley@HansenPartnership.com>,
        Thomas Gleixner <tglx@linutronix.de>
CC: Helge Deller <deller@gmx.de>, linux-parisc@vger.kernel.org,
        John David Anglin <dave.anglin@bell.net>,
        linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] parisc: avoid WARNING: at kernel/cpu/idle.c:96
References: <20130508204242.GA16254@p100.box> <1368047134.8623.5.camel@dabdike>
In-Reply-To: <1368047134.8623.5.camel@dabdike>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
X-TM-AS-MML: No
X-Content-Scanned: Fidelis XPS MAILER
x-cbid: 13051719-5564-0000-0000-000007F915A5
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 05/09/2013 02:35 AM, James Bottomley wrote:
> On Wed, 2013-05-08 at 22:42 +0200, Helge Deller wrote:
>> We need to enable local irqs to avoid this runtime warning.
>>
>> Signed-off-by: Helge Deller <deller@gmx.de>
>>
>> diff --git a/arch/parisc/kernel/process.c b/arch/parisc/kernel/process.c
>> index 55f92b6..2840d43 100644
>> --- a/arch/parisc/kernel/process.c
>> +++ b/arch/parisc/kernel/process.c
>> @@ -286,3 +286,8 @@ void *dereference_function_descriptor(void *ptr)
>>  	return ptr;
>>  }
>>  #endif
>> +
>> +void arch_cpu_idle(void)
>> +{
>> +	local_irq_enable();
> 
> This is definitely wrong.  we'd need at least a cpu_relax() in there.
> Without that the cpu will bounce around in the idle loop.  I'd advise
> that we simply keep the default cpu_idle_poll().
> 
> However, this looks like a kernel bug to me in cpu_idle_loop()?  not
> something we should be working around in the arch code.
> 
> Thomas, what's going on here?  It looks like you can never avoid the
> WARN_ON_ONCE if you don't provide any arch specific idle functions.  If
> you wish to allow this case then the correct patch (keeping the WARN_ON)
> would appear to be this one.
> 
> James
> 
> ----
> diff --git a/kernel/cpu/idle.c b/kernel/cpu/idle.c
> index 8b86c0c..829e41f 100644
> --- a/kernel/cpu/idle.c
> +++ b/kernel/cpu/idle.c
> @@ -56,6 +56,7 @@ void __weak arch_cpu_idle_dead(void) { }
>  void __weak arch_cpu_idle(void)
>  {
>  	cpu_idle_force_poll = 1;
> +	local_irq_enable();
>  }
> 
>  /*
> 

This patch looks like the correct fix to me.

Reviewed-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>

Regards,
Srivatsa S. Bhat