From: Alexander Holler <holler@ahsoftware.de>
To: Peter Hurley <peter@hurleysoftware.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.cz>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] tty: make sure a BUG is hit if tty_port will be destroyed before tty
Date: Fri, 17 May 2013 21:43:54 +0200 [thread overview]
Message-ID: <5196887A.2010906@ahsoftware.de> (raw)
In-Reply-To: <5196835B.4060100@ahsoftware.de>
Am 17.05.2013 21:22, schrieb Alexander Holler:
> The case that the machine didn't die, but just the process, only happens
> when my proposed patch is applied, which prevents the memory corruption.
In short, the proposed BUG_ON() prevents the memory corruption because
it is hit before something bad can happen. The result is that just the
process in question will be killed (and a tty is not released), but only
that BUG_ON() prevents that something _really_ bad happens.
I hope I could describe it now clearly. ;)
Regards,
Alexander
next prev parent reply other threads:[~2013-05-17 19:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-16 6:45 BUG: tty: memory corruption through tty_release/tty_ldisc_release Alexander Holler
2013-05-16 13:15 ` Alexander Holler
2013-05-16 13:47 ` Peter Hurley
2013-05-16 13:59 ` Alexander Holler
2013-05-16 21:53 ` Peter Hurley
2013-05-17 4:43 ` Alexander Holler
2013-05-17 7:12 ` [PATCH] tty: make sure a BUG is hit if tty_port will be destroyed before tty Alexander Holler
2013-05-17 15:31 ` Greg Kroah-Hartman
2013-05-17 16:41 ` Alexander Holler
2013-05-17 18:06 ` Peter Hurley
2013-05-17 19:22 ` Alexander Holler
2013-05-17 19:43 ` Alexander Holler [this message]
2013-05-17 22:51 ` Peter Hurley
2013-05-17 23:41 ` Alexander Holler
2013-06-25 14:18 ` BUG: tty: memory corruption through tty_release/tty_ldisc_release Dean Jenkins
2013-06-26 7:23 ` Alexander Holler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5196887A.2010906@ahsoftware.de \
--to=holler@ahsoftware.de \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=peter@hurleysoftware.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox