* [PATCH] cdrom: gdrom: fix device number leak
@ 2013-05-17 6:19 Libo Chen
2013-05-17 16:53 ` Tejun Heo
2013-05-20 1:34 ` Libo Chen
0 siblings, 2 replies; 3+ messages in thread
From: Libo Chen @ 2013-05-17 6:19 UTC (permalink / raw)
To: gregkh; +Cc: tj, LKML, Andrew Morton, Li Zefan
without this patch, gdrom_major will leak when gd.cd_info alloc faild
Signed-off-by: Libo Chen <libo.chen@huawei.com>
---
drivers/cdrom/gdrom.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/cdrom/gdrom.c b/drivers/cdrom/gdrom.c
index 4afcb65..5980cb9 100644
--- a/drivers/cdrom/gdrom.c
+++ b/drivers/cdrom/gdrom.c
@@ -830,9 +830,9 @@ probe_fail_cdrom_register:
del_gendisk(gd.disk);
probe_fail_no_disk:
kfree(gd.cd_info);
+probe_fail_no_mem:
unregister_blkdev(gdrom_major, GDROM_DEV_NAME);
gdrom_major = 0;
-probe_fail_no_mem:
pr_warning("Probe failed - error is 0x%X\n", err);
return err;
}
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] cdrom: gdrom: fix device number leak
2013-05-17 6:19 [PATCH] cdrom: gdrom: fix device number leak Libo Chen
@ 2013-05-17 16:53 ` Tejun Heo
2013-05-20 1:34 ` Libo Chen
1 sibling, 0 replies; 3+ messages in thread
From: Tejun Heo @ 2013-05-17 16:53 UTC (permalink / raw)
To: Libo Chen; +Cc: gregkh, LKML, Andrew Morton, Li Zefan
On Fri, May 17, 2013 at 02:19:12PM +0800, Libo Chen wrote:
>
> without this patch, gdrom_major will leak when gd.cd_info alloc faild
>
> Signed-off-by: Libo Chen <libo.chen@huawei.com>
Acked-by: Tejun Heo <tj@kernel.org>
This should be routed through the block tree. Can you please repost
with Jens Axboe <axboe@kernel.dk> added?
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] cdrom: gdrom: fix device number leak
2013-05-17 6:19 [PATCH] cdrom: gdrom: fix device number leak Libo Chen
2013-05-17 16:53 ` Tejun Heo
@ 2013-05-20 1:34 ` Libo Chen
1 sibling, 0 replies; 3+ messages in thread
From: Libo Chen @ 2013-05-20 1:34 UTC (permalink / raw)
To: gregkh, axboe; +Cc: tj, LKML, Andrew Morton, Li Zefan
"repost with Jens Axboe <axboe@kernel.dk> added" suggest by Tejun Heo <tj@kernel.org>
without this patch, gdrom_major will leak when gd.cd_info alloc faild
Signed-off-by: Libo Chen <libo.chen@huawei.com>
---
drivers/cdrom/gdrom.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/cdrom/gdrom.c b/drivers/cdrom/gdrom.c
index 4afcb65..5980cb9 100644
--- a/drivers/cdrom/gdrom.c
+++ b/drivers/cdrom/gdrom.c
@@ -830,9 +830,9 @@ probe_fail_cdrom_register:
del_gendisk(gd.disk);
probe_fail_no_disk:
kfree(gd.cd_info);
+probe_fail_no_mem:
unregister_blkdev(gdrom_major, GDROM_DEV_NAME);
gdrom_major = 0;
-probe_fail_no_mem:
pr_warning("Probe failed - error is 0x%X\n", err);
return err;
}
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-05-20 1:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-17 6:19 [PATCH] cdrom: gdrom: fix device number leak Libo Chen
2013-05-17 16:53 ` Tejun Heo
2013-05-20 1:34 ` Libo Chen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox