* [PATCH 3/3] x86 platform drivers: fix gpio leak
[not found] <1368889004-5520-4-git-send-email-libo.chen@huawei.com>
@ 2013-05-20 2:30 ` Libo Chen
0 siblings, 0 replies; only message in thread
From: Libo Chen @ 2013-05-20 2:30 UTC (permalink / raw)
To: matthew.garrett; +Cc: platform-driver-x86, LKML, Li Zefan
when request_irq faild, we should release gpiochip
Signed-off-by: Libo Chen <libo.chen@huawei.com>
---
drivers/platform/x86/intel_pmic_gpio.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
mode change 100644 => 100755 drivers/platform/x86/intel_pmic_gpio.c
diff --git a/drivers/platform/x86/intel_pmic_gpio.c b/drivers/platform/x86/intel_pmic_gpio.c
old mode 100644
new mode 100755
index 6f4b728..478c3a5
--- a/drivers/platform/x86/intel_pmic_gpio.c
+++ b/drivers/platform/x86/intel_pmic_gpio.c
@@ -288,7 +288,7 @@ static int platform_pmic_gpio_probe(struct platform_device *pdev)
retval = request_irq(pg->irq, pmic_irq_handler, 0, "pmic", pg);
if (retval) {
pr_warn("Interrupt request failed\n");
- goto err;
+ goto fail_request_irq;
}
for (i = 0; i < 8; i++) {
@@ -299,6 +299,9 @@ static int platform_pmic_gpio_probe(struct platform_device *pdev)
irq_set_chip_data(i + pg->irq_base, pg);
}
return 0;
+
+fail_request_irq:
+ gpiochip_remove(&pg->chip);
err:
iounmap(pg->gpiointr);
err2:
--
1.8.1.2
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2013-05-20 2:30 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1368889004-5520-4-git-send-email-libo.chen@huawei.com>
2013-05-20 2:30 ` [PATCH 3/3] x86 platform drivers: fix gpio leak Libo Chen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox