* [PATCH] ARM: S5PV210: dependency issue, S5P_SLEEP is depend on ARM_CPU_SUSPEND
@ 2013-05-20 8:54 Chen Gang
2013-05-27 10:05 ` Chen Gang
0 siblings, 1 reply; 5+ messages in thread
From: Chen Gang @ 2013-05-20 8:54 UTC (permalink / raw)
To: ben-linux, kgene.kim@samsung.com
Cc: Russell King - ARM Linux, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org,
linux-kernel@vger.kernel.org >> "linux-kernel@vger.kernel.org"
When randconfig with MMU for arm s5pv210 (and select all cpu type),
need let S5P_SLEEP depend on ARM_CPU_SUSPEND, or will cause issue below:
arch/arm/plat-samsung/built-in.o: In function `s3c_cpu_resume':
arch/arm/plat-samsung/s5p-sleep.S:83: undefined reference to `cpu_resume'
Signed-off-by: Chen Gang <gang.chen@asianux.com>
---
arch/arm/plat-samsung/Kconfig | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/arm/plat-samsung/Kconfig b/arch/arm/plat-samsung/Kconfig
index f8ed2de..1d38541 100644
--- a/arch/arm/plat-samsung/Kconfig
+++ b/arch/arm/plat-samsung/Kconfig
@@ -483,6 +483,7 @@ config S5P_PM
config S5P_SLEEP
bool
+ select ARM_CPU_SUSPEND
help
Internal config node to apply common S5P sleep management code.
Can be selected by S5P and newer SoCs with similar sleep procedure.
--
1.7.7.6
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: S5PV210: dependency issue, S5P_SLEEP is depend on ARM_CPU_SUSPEND
2013-05-20 8:54 [PATCH] ARM: S5PV210: dependency issue, S5P_SLEEP is depend on ARM_CPU_SUSPEND Chen Gang
@ 2013-05-27 10:05 ` Chen Gang
2013-05-27 10:12 ` Kukjin Kim
0 siblings, 1 reply; 5+ messages in thread
From: Chen Gang @ 2013-05-27 10:05 UTC (permalink / raw)
To: ben-linux, kgene.kim@samsung.com
Cc: Russell King - ARM Linux, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org,
linux-kernel@vger.kernel.org >> "linux-kernel@vger.kernel.org",
Linux-Arch
Hello Maintainers:
Please help check this patch whether OK, when you have time.
Thanks.
On 05/20/2013 04:54 PM, Chen Gang wrote:
>
> When randconfig with MMU for arm s5pv210 (and select all cpu type),
> need let S5P_SLEEP depend on ARM_CPU_SUSPEND, or will cause issue below:
>
> arch/arm/plat-samsung/built-in.o: In function `s3c_cpu_resume':
> arch/arm/plat-samsung/s5p-sleep.S:83: undefined reference to `cpu_resume'
>
>
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
> ---
> arch/arm/plat-samsung/Kconfig | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/plat-samsung/Kconfig b/arch/arm/plat-samsung/Kconfig
> index f8ed2de..1d38541 100644
> --- a/arch/arm/plat-samsung/Kconfig
> +++ b/arch/arm/plat-samsung/Kconfig
> @@ -483,6 +483,7 @@ config S5P_PM
>
> config S5P_SLEEP
> bool
> + select ARM_CPU_SUSPEND
> help
> Internal config node to apply common S5P sleep management code.
> Can be selected by S5P and newer SoCs with similar sleep procedure.
>
--
Chen Gang
Asianux Corporation
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH] ARM: S5PV210: dependency issue, S5P_SLEEP is depend on ARM_CPU_SUSPEND
2013-05-27 10:05 ` Chen Gang
@ 2013-05-27 10:12 ` Kukjin Kim
2013-05-27 10:49 ` Chen Gang
0 siblings, 1 reply; 5+ messages in thread
From: Kukjin Kim @ 2013-05-27 10:12 UTC (permalink / raw)
To: 'Chen Gang', ben-linux
Cc: 'Russell King - ARM Linux', linux-arm-kernel,
linux-samsung-soc, linux-kernel, 'Linux-Arch'
Chen Gang wrote:
>
> Hello Maintainers:
>
Hi,
> Please help check this patch whether OK, when you have time.
>
>
> Thanks.
>
> On 05/20/2013 04:54 PM, Chen Gang wrote:
> >
> > When randconfig with MMU for arm s5pv210 (and select all cpu type),
> > need let S5P_SLEEP depend on ARM_CPU_SUSPEND, or will cause issue below:
> >
> > arch/arm/plat-samsung/built-in.o: In function `s3c_cpu_resume':
> > arch/arm/plat-samsung/s5p-sleep.S:83: undefined reference to
> `cpu_resume'
> >
> >
> > Signed-off-by: Chen Gang <gang.chen@asianux.com>
> > ---
> > arch/arm/plat-samsung/Kconfig | 1 +
> > 1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/arch/arm/plat-samsung/Kconfig b/arch/arm/plat-
> samsung/Kconfig
> > index f8ed2de..1d38541 100644
> > --- a/arch/arm/plat-samsung/Kconfig
> > +++ b/arch/arm/plat-samsung/Kconfig
> > @@ -483,6 +483,7 @@ config S5P_PM
> >
> > config S5P_SLEEP
> > bool
> > + select ARM_CPU_SUSPEND
Probably,
+ select ARM_CPU_SUSPEND if PM ?
selecting the S5P_SLEEP depends on PM though...
- Kukjin
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: S5PV210: dependency issue, S5P_SLEEP is depend on ARM_CPU_SUSPEND
2013-05-27 10:12 ` Kukjin Kim
@ 2013-05-27 10:49 ` Chen Gang
2013-05-27 10:57 ` [PATCH v2] arch: arm: plat-samsung: dependency, S5P_SLEEP depends " Chen Gang
0 siblings, 1 reply; 5+ messages in thread
From: Chen Gang @ 2013-05-27 10:49 UTC (permalink / raw)
To: Kukjin Kim
Cc: ben-linux, 'Russell King - ARM Linux', linux-arm-kernel,
linux-samsung-soc, linux-kernel, 'Linux-Arch'
On 05/27/2013 06:12 PM, Kukjin Kim wrote:
>>> config S5P_SLEEP
>>> > > bool
>>> > > + select ARM_CPU_SUSPEND
> Probably,
>
> + select ARM_CPU_SUSPEND if PM ?
>
> selecting the S5P_SLEEP depends on PM though...
After reference another platform, they are really all "select
ARM_CPU_SUSPEND if PM", we'd really better to follow by to let readers
easy understanding.
I will send patch v2.
Thanks.
--
Chen Gang
Asianux Corporation
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] arch: arm: plat-samsung: dependency, S5P_SLEEP depends on ARM_CPU_SUSPEND
2013-05-27 10:49 ` Chen Gang
@ 2013-05-27 10:57 ` Chen Gang
0 siblings, 0 replies; 5+ messages in thread
From: Chen Gang @ 2013-05-27 10:57 UTC (permalink / raw)
To: Kukjin Kim
Cc: ben-linux, 'Russell King - ARM Linux', linux-arm-kernel,
linux-samsung-soc, linux-kernel, 'Linux-Arch'
When randconfig with MMU for arm s5pv210 (and select all cpu type),
need let S5P_SLEEP depend on ARM_CPU_SUSPEND, or will cause issue below:
arch/arm/plat-samsung/built-in.o: In function `s3c_cpu_resume':
arch/arm/plat-samsung/s5p-sleep.S:83: undefined reference to `cpu_resume'
Signed-off-by: Chen Gang <gang.chen@asianux.com>
---
arch/arm/plat-samsung/Kconfig | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/arm/plat-samsung/Kconfig b/arch/arm/plat-samsung/Kconfig
index f8ed2de..b388d93 100644
--- a/arch/arm/plat-samsung/Kconfig
+++ b/arch/arm/plat-samsung/Kconfig
@@ -483,6 +483,7 @@ config S5P_PM
config S5P_SLEEP
bool
+ select ARM_CPU_SUSPEND if PM
help
Internal config node to apply common S5P sleep management code.
Can be selected by S5P and newer SoCs with similar sleep procedure.
--
1.7.7.6
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-05-27 10:58 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-20 8:54 [PATCH] ARM: S5PV210: dependency issue, S5P_SLEEP is depend on ARM_CPU_SUSPEND Chen Gang
2013-05-27 10:05 ` Chen Gang
2013-05-27 10:12 ` Kukjin Kim
2013-05-27 10:49 ` Chen Gang
2013-05-27 10:57 ` [PATCH v2] arch: arm: plat-samsung: dependency, S5P_SLEEP depends " Chen Gang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox