From: Eliezer Tamir <eliezer.tamir@linux.intel.com>
To: David Miller <davem@davemloft.net>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
jesse.brandeburg@intel.com, "Skidmore,
Donald C" <donald.c.skidmore@intel.com>,
e1000-devel@lists.sourceforge.net, willemb@google.com,
andi@firstfloor.org, hpa@zytor.com, eliezer@tamir.org.il
Subject: Re: [PATCH v2 net-next 1/4] net: implement support for low latency socket polling
Date: Mon, 20 May 2013 12:39:59 +0300 [thread overview]
Message-ID: <5199EF6F.9040008@linux.intel.com> (raw)
In-Reply-To: <20130520.005447.972811583292360876.davem@davemloft.net>
On 20/05/2013 10:54, David Miller wrote:
> From: Eliezer Tamir <eliezer.tamir@linux.intel.com>
> Date: Sun, 19 May 2013 13:25:33 +0300
>
>> +#else /* CONFIG_INET_LL_RX_FLUSH */
>> +
>> +#define sk_valid_ll(sk) 0
>> +#define sk_poll_ll(sk, nonblock) do {} while (0)
>> +#define skb_mark_ll(napi, skb) do {} while (0)
>> +#define sk_mark_ll(sk, skb) do {} while (0)
>
> Make these inline functions too, so that even if
> CONFIG_INET_LL_RX_POLL is disabled, the arguments and return values
> are still properly type checked.
Is this what you had in mind?
static inline bool sk_valid_ll(struct sock *sk)
{
return 0;
}
static inline bool sk_poll_ll(struct sock *sk, int noblock)
{
return 0;
}
static inline void skb_mark_ll(struct sk_buff *skb, struct napi_struct
*napi)
{
}
static inline voiv sk_mark_ll(struct sock *sk, struct sk_buff *skb)
{
}
would you like me to resend the whole set or just this patch?
Thanks,
Eliezer
next prev parent reply other threads:[~2013-05-20 9:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-19 10:25 [PATCH v2 net-next 0/4] net: low latency Ethernet device polling Eliezer Tamir
2013-05-19 10:25 ` [PATCH v2 net-next 1/4] net: implement support for low latency socket polling Eliezer Tamir
2013-05-20 7:54 ` David Miller
2013-05-20 8:29 ` Joe Perches
2013-05-20 9:16 ` David Miller
2013-05-20 9:39 ` Eliezer Tamir [this message]
2013-05-20 19:34 ` David Miller
2013-05-20 16:22 ` Andi Kleen
2013-05-21 6:16 ` Eliezer Tamir
2013-05-19 10:25 ` [PATCH v2 net-next 2/4] tcp: add TCP support for low latency receive poll Eliezer Tamir
2013-05-19 10:25 ` [PATCH v2 net-next 3/4] ixgbe: Add support for ndo_ll_poll Eliezer Tamir
2013-05-19 10:26 ` [PATCH v2 net-next 4/4] ixgbe: add extra stats " Eliezer Tamir
2013-05-19 19:06 ` [PATCH v2 net-next 0/4] net: low latency Ethernet device polling Or Gerlitz
2013-05-19 19:20 ` Eliezer Tamir
2013-05-20 20:09 ` [E1000-devel] " Jeff Kirsher
2013-05-19 19:25 ` Eliezer Tamir
[not found] ` <CAJZOPZ+8zKfuuUhOwzz6WKm6do6N25B1DAmv+aOipSLbvdh6LA@mail.gmail.com>
2013-05-20 10:26 ` Eliezer Tamir
2013-05-20 22:44 ` Brandeburg, Jesse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5199EF6F.9040008@linux.intel.com \
--to=eliezer.tamir@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=davem@davemloft.net \
--cc=donald.c.skidmore@intel.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=eliezer@tamir.org.il \
--cc=hpa@zytor.com \
--cc=jesse.brandeburg@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox