From: Clemens Ladisch <clemens@ladisch.de>
To: good1.2guy@gmail.com
Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org
Subject: Re: [Alsa-devel] add support for syba 7.1 surround sound card
Date: Tue, 21 May 2013 10:50:57 +0200 [thread overview]
Message-ID: <519B3571.3070601@ladisch.de> (raw)
In-Reply-To: <51804394.a36cec0a.2c7d.291b@mx.google.com>
good1.2guy@gmail.com wrote:
> Summary: add support for syba 7.1 surround sound card
> Keywords: syba via VT1723 Tremor
> Kernel: 3.8.8-203.fc18.x86_64
What are these three lines for?
> add support for syba 7.1 surround sound card
> actually the card only has 6 dmas, so it is really only 5.1
The website shows a daughterboard.
> added code to force_rate setting to not fail EBUSY when the dmas are running.
> suggest using force_rate with pulseaudio to avoid loops with error logging.
This sounds as if it has nothing to do with this particular SYBA card
but affects all VT1723 cards. Please move it into a separate patch.
And there should be no reason for a module parameter; if this is a bug
in the driver and/or in PulseAudio, it should be just fixed.
> Signed-off-by: psmith2004@yahoo.com
Real names only.
Please read Documentation/SubmittingPatches.
> +static void syba_quirk_open(struct snd_ice1712 *ice)
> +{
> + unsigned long flags;
It's common to have an empty line here.
> + spin_lock_irqsave(&ice->reg_lock, flags);
> + outb(0xff, ICEREG1724(ice, AC97_CFG));
> + udelay(500);
> + outb(ice->eeprom.data[ICE_EEP2_ACLINK], ICEREG1724(ice, AC97_CFG));
> + spin_unlock_irqrestore(&ice->reg_lock, flags);
> +}
What is the reason for this quirk?
Is it possible that this might be needed for other cards using a AC'97
codec?
Regards,
Clemens
prev parent reply other threads:[~2013-05-21 9:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-30 22:20 add support for syba 7.1 surround sound card good1.2guy
2013-05-21 8:50 ` Clemens Ladisch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=519B3571.3070601@ladisch.de \
--to=clemens@ladisch.de \
--cc=alsa-devel@alsa-project.org \
--cc=good1.2guy@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox