From: Peter Hurley <peter@hurleysoftware.com>
To: Wang YanQing <udknight@gmail.com>
Cc: gregkh@linuxfoundation.org, sfr@canb.auug.org.au,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] TTY:vt: convert remain take_over_console's users to do_take_over_console
Date: Tue, 21 May 2013 11:48:58 -0400 [thread overview]
Message-ID: <519B976A.3050708@hurleysoftware.com> (raw)
In-Reply-To: <20130521144215.GA5302@udknight.homenetwork>
On 05/21/2013 10:42 AM, Wang YanQing wrote:
> On Tue, May 21, 2013 at 09:10:33AM -0400, Peter Hurley wrote:
>> I would rather revert dc9641895abb which purported to delete
>> _unneeded_ functions than have this. Obviously the functions
>> were needed.
>>
>
> Hi Peter, this series patches' goal is to reduce codes'
> redundance and function duplication. But if we keep take_over_console,
> then we have to rewrite it as a trivial wrapper over do_take_over_console,
> or we have to keep bind_con_driver and register_con_driver, and this
> will bring use codes' redundance.
>
> And if we rewrite take_over_console as a wrapper over
> do_take_over_console, it is so trivial, delete it and let kernel
> use the unified version of APIs will simplify the APIs.
Except now you're spreading the brokenness that is console_lock()
over many more source files than the single-use case of
do_take_over_console().
The actual interface is take_over_console(); the _workaround_ is
exposing do_take_over_console() for fbcon to wrap.
Regards,
Peter Hurley
next prev parent reply other threads:[~2013-05-21 15:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-21 5:15 [PATCH] TTY:vt: convert remain take_over_console's users to do_take_over_console Wang YanQing
2013-05-21 13:10 ` Peter Hurley
2013-05-21 14:42 ` Wang YanQing
2013-05-21 15:48 ` Peter Hurley [this message]
2013-05-21 16:18 ` Wang YanQing
2013-05-21 16:29 ` Wang YanQing
2013-05-21 17:45 ` Peter Hurley
2013-06-04 20:13 ` Pavel Machek
2013-06-06 1:23 ` Wang YanQing
2013-06-06 11:47 ` Pavel Machek
2013-06-06 14:22 ` Wang YanQing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=519B976A.3050708@hurleysoftware.com \
--to=peter@hurleysoftware.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=udknight@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox