Re: [PATCH v4 net-next 3/4] ixgbe: Add support for ndo_ll_poll

Ben Hutchings
2013-05-21T17:33:43Z

On Tue, 2013-05-21 at 17:27 +0300, Eliezer Tamir wrote:
> Add the ixgbe driver code implementing ndo_ll_poll.
> It should be easy for other drivers to do something similar
> in order to enable support for CONFIG_INET_LL_RX_POLL
[...]
> --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_lib.c
> +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_lib.c
> @@ -1019,6 +1019,8 @@ static void ixgbe_free_q_vectors(struct ixgbe_adapter *adapter)
> adapter->num_rx_queues = 0;
> adapter->num_q_vectors = 0;
>
> + inc_ll_gen_id();

I think that should be handled by the networking core (somewhere) and
not by drivers.

Ben.

> while (v_idx--)
> ixgbe_free_q_vector(adapter, v_idx);
> }
[...]

--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.