Re: [ANNOUNCE] ktap 0.1 released

["zhangwei(Jovi)" <jovi.zhangwei@huawei.com>]

On 2013/5/22 12:34, Ming Lei wrote:
> On Wed, May 22, 2013 at 12:19 PM, Ming Lei <tom.leiming@gmail.com> wrote:
>> On Wed, May 22, 2013 at 12:15 PM, Ming Lei <tom.leiming@gmail.com> wrote:
>>> On Tue, May 21, 2013 at 11:56 AM, zhangwei(Jovi)
>>>
>>> Nice job, I have run it on ARM already with only one line change.
>>>
>>> But looks 'Control-C' can't stop the tracing or need some time to complete it,
>>> see below:
>>
>> Sometimes, it doesn't work:
>>
>> $ sudo ./ktap ./scripts/kretprobe.kp
>> ......
>> vfs_read! (execname sshd); retval:38
>> ^Cvfs_read! (execname sshd); retval:38
>>
>> probe ending
>> vfs_read! (execname sshd); retval:48
>> vfs_read! (execname sshd); retval:2
>> ^C
>> ^C^C^C
>> ^C^C^C^C^C^C^C
>>
>> ^C^C^C^C^C^C
> 
> This one can be fixed by below patch, but can't work on
> the last one.
> 
> diff --git a/vm.c b/vm.c
> index c5f5733..a24a389 100644
> --- a/vm.c
> +++ b/vm.c
> @@ -1060,7 +1060,7 @@ ktap_State *kp_newthread(ktap_State *mainthread)
> 
>  void kp_user_complete(ktap_State *ks)
>  {
> -	if (!ks || !G(ks)->user_completion)
> +	if (!ks || !G(ks) || !G(ks)->user_completion)
>  		return;
> 
>  	complete(G(ks)->user_completion);
> 
> 
> 
> Thanks,
> 
Hi Ming,

Thanks for testing and your fix.

the ktap exit mechanism is not quite safe as you saw, so I plan to rewrite the logic
to make more safer, hopefully I could complete this work in next few days.

.jovi