From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756160Ab3EVTES (ORCPT ); Wed, 22 May 2013 15:04:18 -0400 Received: from mail-la0-f41.google.com ([209.85.215.41]:43283 "EHLO mail-la0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754087Ab3EVTER (ORCPT ); Wed, 22 May 2013 15:04:17 -0400 Message-ID: <519D16B4.7080905@cogentembedded.com> Date: Wed, 22 May 2013 23:04:20 +0400 From: Sergei Shtylyov User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130509 Thunderbird/17.0.6 MIME-Version: 1.0 To: Jiri Slaby CC: jirislaby@gmail.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, Jeff Mahoney , Patrick Koppen , Karsten Keil , netdev@vger.kernel.org, "David S. Miller" Subject: Re: [PATCH -resend 1/6] mISDN: Add support for group membership check References: <1369227552-11743-1-git-send-email-jslaby@suse.cz> In-Reply-To: <1369227552-11743-1-git-send-email-jslaby@suse.cz> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 22-05-2013 16:59, Jiri Slaby wrote: > From: Jeff Mahoney > This patch adds a module parameter to allow a group access to the > mISDN devices. Otherwise, unpriviledged users on systems with ISDN > hardware have the ability to dial out, potentially causing expensive > bills. > Based on a different implementation by Patrick Koppen > Acked-by: Jeff Mahoney > Cc: Patrick Koppen > Signed-off-by: Jiri Slaby > Cc: Karsten Keil > Cc: netdev@vger.kernel.org > Cc: "David S. Miller" > --- > drivers/isdn/mISDN/core.c | 3 +++ > drivers/isdn/mISDN/core.h | 1 + > drivers/isdn/mISDN/socket.c | 8 ++++++++ > 3 files changed, 12 insertions(+) [...] > diff --git a/drivers/isdn/mISDN/socket.c b/drivers/isdn/mISDN/socket.c > index e47dcb9..71f4986 100644 > --- a/drivers/isdn/mISDN/socket.c > +++ b/drivers/isdn/mISDN/socket.c > @@ -612,6 +612,10 @@ data_sock_create(struct net *net, struct socket *sock, int protocol) > { > struct sock *sk; > > + if(!capable(CAP_SYS_ADMIN) && (misdn_permitted_gid != current_gid()) Did you run this thru scripts/checkpatch.pl? There should be space after *if*. Also, () around != are not neccessary... > @@ -694,6 +698,10 @@ base_sock_ioctl(struct socket *sock, unsigned int cmd, unsigned long arg) > case IMSETDEVNAME: > { > struct mISDN_devrename dn; > + if(!capable(CAP_SYS_ADMIN) Again, need space after *if*. > + && (misdn_permitted_gid != current_gid()) Better leave && on a previous line and align the line under !. () again are not necessary. > + && (!in_group_p(misdn_permitted_gid))) () around !x are simply not needed -- ! operator has very high priority. WBR, Sergei