* [PATCH] drivers: iio: adc: convert to devm_ioremap_resource()
@ 2013-05-11 11:06 Silviu-Mihai Popescu
2013-05-22 21:21 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Silviu-Mihai Popescu @ 2013-05-11 11:06 UTC (permalink / raw)
To: linux-iio
Cc: Jonathan Cameron, Naveen Krishna Chatradhi, Lars-Peter Clausen,
Sachin Kamat, linux-kernel, Silviu-Mihai Popescu
Convert all uses of devm_request_and_ioremap() to the newly introduced
devm_ioremap_resource() which provides more consistent error handling.
Signed-off-by: Silviu-Mihai Popescu <silviupopescu1990@gmail.com>
---
drivers/iio/adc/exynos_adc.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/iio/adc/exynos_adc.c b/drivers/iio/adc/exynos_adc.c
index 9f3a8ef..22d034a 100644
--- a/drivers/iio/adc/exynos_adc.c
+++ b/drivers/iio/adc/exynos_adc.c
@@ -270,16 +270,16 @@ static int exynos_adc_probe(struct platform_device *pdev)
info = iio_priv(indio_dev);
mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- info->regs = devm_request_and_ioremap(&pdev->dev, mem);
- if (!info->regs) {
- ret = -ENOMEM;
+ info->regs = devm_ioremap_resource(&pdev->dev, mem);
+ if (IS_ERR(info->regs)) {
+ ret = PTR_ERR(info->regs);
goto err_iio;
}
mem = platform_get_resource(pdev, IORESOURCE_MEM, 1);
- info->enable_reg = devm_request_and_ioremap(&pdev->dev, mem);
- if (!info->enable_reg) {
- ret = -ENOMEM;
+ info->enable_reg = devm_ioremap_resource(&pdev->dev, mem);
+ if (IS_ERR(info->enable_reg)) {
+ ret = PTR_ERR(info->enable_reg);
goto err_iio;
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drivers: iio: adc: convert to devm_ioremap_resource()
2013-05-11 11:06 [PATCH] drivers: iio: adc: convert to devm_ioremap_resource() Silviu-Mihai Popescu
@ 2013-05-22 21:21 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2013-05-22 21:21 UTC (permalink / raw)
To: Silviu-Mihai Popescu
Cc: linux-iio, Jonathan Cameron, Naveen Krishna Chatradhi,
Lars-Peter Clausen, Sachin Kamat, linux-kernel
On 05/11/2013 12:06 PM, Silviu-Mihai Popescu wrote:
> Convert all uses of devm_request_and_ioremap() to the newly introduced
> devm_ioremap_resource() which provides more consistent error handling.
>
> Signed-off-by: Silviu-Mihai Popescu <silviupopescu1990@gmail.com>
Patch number 3 doing the same thing. I was somewhat tardy applying
the first one so sorry for wasting your time on this.
Jonathan
> ---
> drivers/iio/adc/exynos_adc.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/iio/adc/exynos_adc.c b/drivers/iio/adc/exynos_adc.c
> index 9f3a8ef..22d034a 100644
> --- a/drivers/iio/adc/exynos_adc.c
> +++ b/drivers/iio/adc/exynos_adc.c
> @@ -270,16 +270,16 @@ static int exynos_adc_probe(struct platform_device *pdev)
> info = iio_priv(indio_dev);
>
> mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - info->regs = devm_request_and_ioremap(&pdev->dev, mem);
> - if (!info->regs) {
> - ret = -ENOMEM;
> + info->regs = devm_ioremap_resource(&pdev->dev, mem);
> + if (IS_ERR(info->regs)) {
> + ret = PTR_ERR(info->regs);
> goto err_iio;
> }
>
> mem = platform_get_resource(pdev, IORESOURCE_MEM, 1);
> - info->enable_reg = devm_request_and_ioremap(&pdev->dev, mem);
> - if (!info->enable_reg) {
> - ret = -ENOMEM;
> + info->enable_reg = devm_ioremap_resource(&pdev->dev, mem);
> + if (IS_ERR(info->enable_reg)) {
> + ret = PTR_ERR(info->enable_reg);
> goto err_iio;
> }
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-22 21:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-11 11:06 [PATCH] drivers: iio: adc: convert to devm_ioremap_resource() Silviu-Mihai Popescu
2013-05-22 21:21 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox