From: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
To: Wei Yongjun <weiyj.lk@gmail.com>
Cc: forest@alittletooquiet.net, gregkh@linuxfoundation.org,
joe@perches.com, hemaklnce@gmail.com, marcos.souza.org@gmail.com,
yongjun_wei@trendmicro.com.cn, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] Staging: vt6655: add missing free_netdev() on error in hostap_enable_hostapd()
Date: Thu, 23 May 2013 07:21:44 -0700 [thread overview]
Message-ID: <519E25F8.8020905@intel.com> (raw)
In-Reply-To: <CAPgLHd_qqOWWnWFXYbAks3LmhCcH3hGaqCw9KT+bkLwZazSCbA@mail.gmail.com>
On 05/23/2013 02:28 AM, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Add the missing free_netdev() before return from function
> hostap_enable_hostapd() in the error handling case.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
> drivers/staging/vt6655/hostap.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/staging/vt6655/hostap.c b/drivers/staging/vt6655/hostap.c
> index 46f097d..57a08c5 100644
> --- a/drivers/staging/vt6655/hostap.c
> +++ b/drivers/staging/vt6655/hostap.c
> @@ -104,6 +104,8 @@ static int hostap_enable_hostapd(PSDevice pDevice, int rtnl_locked)
> if (ret) {
> DBG_PRT(MSG_LEVEL_DEBUG, KERN_INFO "%s: register_netdevice(AP) failed!\n",
> dev->name);
> + free_netdev(pDevice->apdev);
> + pDevice->apdev = NULL;
> return -1;
> }
>
>
This looks good to me.
-PJ
prev parent reply other threads:[~2013-05-23 14:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-23 9:28 [PATCH -next] Staging: vt6655: add missing free_netdev() on error in hostap_enable_hostapd() Wei Yongjun
2013-05-23 14:21 ` Peter P Waskiewicz Jr [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=519E25F8.8020905@intel.com \
--to=peter.p.waskiewicz.jr@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=forest@alittletooquiet.net \
--cc=gregkh@linuxfoundation.org \
--cc=hemaklnce@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcos.souza.org@gmail.com \
--cc=weiyj.lk@gmail.com \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox