Re: [Suggestion] fs/namespace.c: the direct cause of the warning for: "ida_remove called for id=0 which is not allocated" with mnt_release_group_id()

[Chen Gang <gang.chen@asianux.com>]

> From: Takashi Iwai <tiwai@suse.de>
> Subject: vfs: fix invalid ida_remove() call
> 
> When the group id of a shared mount is not allocated, the umount still
> tries to call mnt_release_group_id(), which eventually hits a kernel
> warning at ida_remove() spewing a message like:
> 
>   ida_remove called for id=0 which is not allocated.
> 
> This patch fixes the bug simply checking the group id in the caller.
> 
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
> Reported-by: Cristian Rodr�guez <crrodriguez@opensuse.org>
> Cc: Al Viro <viro@zeniv.linux.org.uk>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
> 

Tested-by Chen Gang <gang.chen@asianux.com>

Thanks.


>  fs/pnode.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff -puN fs/pnode.c~vfs-fix-invalid-ida_remove-call fs/pnode.c
> --- a/fs/pnode.c~vfs-fix-invalid-ida_remove-call
> +++ a/fs/pnode.c
> @@ -83,7 +83,8 @@ static int do_make_slave(struct mount *m
>  		if (peer_mnt == mnt)
>  			peer_mnt = NULL;
>  	}
> -	if (IS_MNT_SHARED(mnt) && list_empty(&mnt->mnt_share))
> +	if (mnt->mnt_group_id && IS_MNT_SHARED(mnt) &&
> +	    list_empty(&mnt->mnt_share))
>  		mnt_release_group_id(mnt);
>  
>  	list_del_init(&mnt->mnt_share);
> _
> 
> 
> 


-- 
Chen Gang

Asianux Corporation