public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: boris brezillon <b.brezillon@overkiz.com>
To: Thierry Reding <thierry.reding@avionic-design.de>
Cc: linux-kernel@vger.kernel.org,
	Nicolas Ferre <nicolas.ferre@atmel.com>,
	Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
Subject: Re: [RESEND PATCH] pwm: pwm-atmel-tcb: pinctrl support
Date: Fri, 24 May 2013 10:15:54 +0200	[thread overview]
Message-ID: <519F21BA.6040403@overkiz.com> (raw)
In-Reply-To: <20130523193545.GF17462@avionic-0098.adnet.avionic-design.de>

On 23/05/2013 21:35, Thierry Reding wrote:
> On Thu, May 23, 2013 at 06:38:52PM +0200, Boris BREZILLON wrote:
>> Hello,
>>
>> I sent a patch 1 month ago to add pinctrl support to pwm-atmel-tcb
>> driver and didn't get any review.
>>
>> Could you take a look?
>>
>> This patch adds pins request for the pwm device exposed by the TC
>> block using the pinctrl subsystem.
> I was actually looking at this a few days back and thought I remembered
> this being handled in the core now. There was some discussion about this
> back in January (?) as far as I remember. I just verified that indeed
> there is code in the driver core code to do this. See commit:
>
> 	ab78029ecc347debbd737f06688d788bd9d60c1d  drivers/pinctrl: grab default handles from device core
>
> Are you sure this is really necessary in the driver?
No.

Thanks for pointing this commit out (I didn't notice the default handles 
were grabbed
from device core).

I'll test it without this patch.

Best Regards,
Boris
> Thierry


  reply	other threads:[~2013-05-24  8:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-23 16:38 [RESEND PATCH] pwm: pwm-atmel-tcb: pinctrl support Boris BREZILLON
2013-05-23 19:35 ` Thierry Reding
2013-05-24  8:15   ` boris brezillon [this message]
2013-05-24 19:45     ` Jean-Christophe PLAGNIOL-VILLARD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=519F21BA.6040403@overkiz.com \
    --to=b.brezillon@overkiz.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nicolas.ferre@atmel.com \
    --cc=plagnioj@jcrosoft.com \
    --cc=thierry.reding@avionic-design.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox