Re: [PATCH v3 2/9] media: davinci: vpif: Convert to devm_* api

[Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>]

Hello.

On 26-05-2013 16:00, Prabhakar Lad wrote:

> From: Lad, Prabhakar <prabhakar.csengg@gmail.com>

> Use devm_ioremap_resource instead of reques_mem_region()/ioremap().
> This ensures more consistent error values and simplifies error paths.

> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
>   drivers/media/platform/davinci/vpif.c |   27 ++++-----------------------
>   1 files changed, 4 insertions(+), 23 deletions(-)

> diff --git a/drivers/media/platform/davinci/vpif.c b/drivers/media/platform/davinci/vpif.c
> index 761c825..f857d8f 100644
> --- a/drivers/media/platform/davinci/vpif.c
> +++ b/drivers/media/platform/davinci/vpif.c
[...]
> @@ -421,23 +419,12 @@ EXPORT_SYMBOL(vpif_channel_getfid);
>
>   static int vpif_probe(struct platform_device *pdev)
>   {
> -	int status = 0;
> +	static struct resource	*res;
>
>   	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
[...]
> +	vpif_base = devm_request_and_ioremap(&pdev->dev, res);

    No, don't use this deprecated funtion please. Undo to 
devm_ioremap_resource().

> +	if (IS_ERR(vpif_base))

     NAK, devm_request_and_ioremap() doesn't rethrn error cpdes, only 
NULL. BTW, it's implemented via a call to devm_ioremap_resource() now.
Is it so hard to look at the code that you've calling?

> +		return PTR_ERR(vpif_base);

WBR, Sergei