Re: [PATCH] arch: blackfin: kernel: using strlcpy instead of strncpy

[Chen Gang <gang.chen@asianux.com>]

On 05/26/2013 03:04 PM, Chen Gang wrote:
> 
> For NULL terminated string, need always be sure of ended by zero.
> 
> 'command_line' is a static variable which will be initialized
> automatically, and cmdline_init() is __init function, so need not
> initialize it again, can just use strlcpy instead of strncpy.
> 

The 2nd paragraph comment is redundent, need delete. I will send patch v2.

> 
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
> ---
>  arch/blackfin/kernel/setup.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/blackfin/kernel/setup.c b/arch/blackfin/kernel/setup.c
> index 107b306..c731ec7 100644
> --- a/arch/blackfin/kernel/setup.c
> +++ b/arch/blackfin/kernel/setup.c
> @@ -1458,5 +1458,5 @@ void __init cmdline_init(const char *r0)
>  {
>  	early_shadow_stamp();
>  	if (r0)
> -		strncpy(command_line, r0, COMMAND_LINE_SIZE);
> +		strlcpy(command_line, r0, COMMAND_LINE_SIZE);
>  }
> 


-- 
Chen Gang

Asianux Corporation