From: daniel jeong <gshark.jeong@gmail.com>
To: Axel Lin <axel.lin@ingics.com>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regulator: lp8755: Use LP8755_BUCK_MAX instead of magic number
Date: Sun, 27 Jan 2013 02:42:06 +0900 [thread overview]
Message-ID: <51A2EA10-91C6-45DA-B138-AF2CDC07FD90@gmail.com> (raw)
In-Reply-To: <1359177587.9041.1.camel@phoenix>
On Jan 26, 2013, at 2:19 PM, Axel Lin <axel.lin@ingics.com> wrote:
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/regulator/lp8755.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/regulator/lp8755.c b/drivers/regulator/lp8755.c
> index 8b1ce0f..f0f6ea0 100644
> --- a/drivers/regulator/lp8755.c
> +++ b/drivers/regulator/lp8755.c
> @@ -373,7 +373,7 @@ static irqreturn_t lp8755_irq_handler(int irq, void *data)
> goto err_i2c;
>
> /* sent power fault detection event to specific regulator */
> - for (icnt = 0; icnt < 6; icnt++)
> + for (icnt = 0; icnt < LP8755_BUCK_MAX; icnt++)
> if ((flag0 & (0x4 << icnt))
> && (pchip->irqmask & (0x04 << icnt))
> && (pchip->rdev[icnt] != NULL))
> @@ -508,7 +508,7 @@ err_irq:
>
> err_regulator:
> /* output disable */
> - for (icnt = 0; icnt < 0x06; icnt++)
> + for (icnt = 0; icnt < LP8755_BUCK_MAX; icnt++)
> lp8755_write(pchip, icnt, 0x00);
>
> return ret;
> @@ -522,7 +522,7 @@ static int lp8755_remove(struct i2c_client *client)
> for (icnt = 0; icnt < mphase_buck[pchip->mphase].nreg; icnt++)
> regulator_unregister(pchip->rdev[icnt]);
>
> - for (icnt = 0; icnt < 0x06; icnt++)
> + for (icnt = 0; icnt < LP8755_BUCK_MAX; icnt++)
> lp8755_write(pchip, icnt, 0x00);
>
> if (pchip->irq != 0)
> --
> 1.7.9.5
>
>
>
Yes you're right!
Thank you Axel.
Daniel.
next prev parent reply other threads:[~2013-01-26 17:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-26 5:19 [PATCH] regulator: lp8755: Use LP8755_BUCK_MAX instead of magic number Axel Lin
2013-01-26 17:42 ` daniel jeong [this message]
2013-01-27 3:00 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51A2EA10-91C6-45DA-B138-AF2CDC07FD90@gmail.com \
--to=gshark.jeong@gmail.com \
--cc=axel.lin@ingics.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox