From: Chanwoo Choi <cw00.choi@samsung.com>
To: Kishon Vijay Abraham I <kishon@ti.com>
Cc: myungjoo.ham@samsung.com, balbi@ti.com, ldewangan@nvidia.com,
gg@slimlogic.co.uk, lgirdwood@gmail.com, broonie@kernel.org,
devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
linux-omap@vger.kernel.org, grant.likely@linaro.org,
rob.herring@calxeda.com, rob@landley.net,
gregkh@linuxfoundation.org, george.cherian@ti.com,
sameo@linux.intel.com
Subject: Re: [PATCH v5 2/3] extcon: Palmas Extcon Driver
Date: Mon, 27 May 2013 15:08:13 +0900 [thread overview]
Message-ID: <51A2F84D.9030605@samsung.com> (raw)
In-Reply-To: <51A2F512.2090907@ti.com>
On 05/27/2013 02:54 PM, Kishon Vijay Abraham I wrote:
> Hi,
>
> On Monday 27 May 2013 11:04 AM, Chanwoo Choi wrote:
>> Hi Kishon,
>>
>> I have some comment about this patch
>> and upload modified patch to following repository (extcon-for-palmas).
>> - http://git.kernel.org/cgit/linux/kernel/git/chanwoo/extcon.git/commit/?h=extcon-for-palmas&id=f2b7cb80699cbe1a5fd6c97ef2c600915f8d7f2c
>>
>> This patchset include patch related to other module
>> ,so I need your opinion to apply this patchset to git repository.
>
> yeah.. Still there is some confusion with palmas_set_switch_smps10(). I think we can remove it for now and add it separately later. By this at least we can have device mode fully functional in OMAP5. What do you think?
>
I agree your opinion.
But, I propose some fixes about palmas_set_switch_smps10().
I dont' prefer to call global function in exton-palmas.c from palmas-regulator.c.
So, Why don't you use regulator consumer instead of global function?
You can register specific regulator for enabling or disabling SMPS10_SWITCH_EN
and then control SMPS10_SWITCH_EN bit through regulator framework in extcon-palmas.c
without calling global function.
Thanks,
Chanwoo Choi
next prev parent reply other threads:[~2013-05-27 6:08 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-24 14:31 [PATCH 0/3] palmas usb driver Kishon Vijay Abraham I
2013-05-24 14:31 ` [PATCH 1/3] drivers: regulator: palmas: add an API to set/clear the switch bit on SMPS10 Kishon Vijay Abraham I
2013-05-24 15:09 ` Sergei Shtylyov
2013-05-25 17:00 ` Laxman Dewangan
2013-05-24 14:31 ` [PATCH v5 2/3] extcon: Palmas Extcon Driver Kishon Vijay Abraham I
2013-05-25 17:10 ` Laxman Dewangan
2013-05-27 5:34 ` Chanwoo Choi
2013-05-27 5:54 ` Kishon Vijay Abraham I
2013-05-27 6:08 ` Chanwoo Choi [this message]
2013-05-27 6:22 ` Laxman Dewangan
2013-05-27 6:31 ` Kishon Vijay Abraham I
2013-05-27 6:36 ` Laxman Dewangan
2013-05-27 6:41 ` Kishon Vijay Abraham I
2013-05-27 6:56 ` Laxman Dewangan
2013-05-27 9:24 ` Kishon Vijay Abraham I
2013-05-24 14:31 ` [PATCH 3/3] usb: dwc3: use extcon fwrk to receive connect/disconnect notification Kishon Vijay Abraham I
2013-05-27 5:38 ` Chanwoo Choi
2013-05-30 23:45 ` Chanwoo Choi
2013-05-27 13:33 ` [PATCH v6] extcon: Palmas Extcon Driver Kishon Vijay Abraham I
2013-05-28 2:51 ` Chanwoo Choi
2013-05-27 13:35 ` [PATCH v2] usb: dwc3: use extcon fwrk to receive connect/disconnect notification Kishon Vijay Abraham I
2013-05-28 2:24 ` Chanwoo Choi
2013-05-28 5:27 ` Kishon Vijay Abraham I
2013-05-28 17:35 ` [PATCH 0/3] palmas usb driver Felipe Balbi
2013-05-29 6:06 ` Kishon Vijay Abraham I
2013-05-29 17:38 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51A2F84D.9030605@samsung.com \
--to=cw00.choi@samsung.com \
--cc=balbi@ti.com \
--cc=broonie@kernel.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=george.cherian@ti.com \
--cc=gg@slimlogic.co.uk \
--cc=grant.likely@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=kishon@ti.com \
--cc=ldewangan@nvidia.com \
--cc=lgirdwood@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).